Feature/support sort order in identities #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoangdat
reviewed
Dec 26, 2022
hoangdat
reviewed
Dec 26, 2022
dab246
reviewed
Dec 27, 2022
sherlockvn
force-pushed
the
feature/support-sort-order-in-identities
branch
from
284e31e to
4f378ae
Compare
dab246
reviewed
Dec 27, 2022
sherlockvn
force-pushed
the
feature/support-sort-order-in-identities
branch
2 times, most recently
from
fdf6b2d to
74e1561
Compare
sherlockvn
force-pushed
the
feature/support-sort-order-in-identities
branch
2 times, most recently
from
36069ec to
bf43f49
Compare
hoangdat
reviewed
Dec 27, 2022
| import 'package:jmap_dart_client/jmap/mail/email/email_address.dart'; | ||
|
|
||
| void main() { | ||
| group('test to json get identity method', () { |
There was a problem hiding this comment.
@sherlockvn please add the test for the case:
- increase
sortOrderof default Identity - create new default Identity
All in one request
hoangdat
approved these changes
Dec 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.