Skip to content

Add some error type for method response #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Add some error type for method response #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions lib/jmap/core/error/method/error_method_response.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ abstract class ErrorMethodResponse extends MethodResponse {
static final accountNotFound = ErrorType("accountNotFound");
static final accountNotSupportedByMethod = ErrorType("accountNotSupportedByMethod");
static final accountReadOnly = ErrorType("accountReadOnly");
static final cannotCalculateChanges = ErrorType("cannotCalculateChanges");

final ErrorType type;
final String? description;
Expand Down Expand Up @@ -62,4 +63,20 @@ class AccountNotSupportedByMethod extends ErrorMethodResponse {

class AccountReadOnly extends ErrorMethodResponse {
AccountReadOnly({String? description}) : super(ErrorMethodResponse.accountReadOnly, description: description);
}

class CannotCalculateChangesMethodResponse extends ErrorMethodResponse {
CannotCalculateChangesMethodResponse({String? description}) : super(
ErrorMethodResponse.cannotCalculateChanges,
description: description);
}

class UndefinedErrorMethodResponse extends ErrorMethodResponse {
UndefinedErrorMethodResponse(
ErrorType errorType,
{String? description}
) : super(
errorType,
description: description
);
}
6 changes: 5 additions & 1 deletion lib/jmap/core/response/response_object.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,12 @@ class ResponseObject with EquatableMixin {
return ServerUnavailableMethodResponse(description: description);
} else if (errorType == ErrorMethodResponse.unknownMethod) {
return UnknownMethodResponse(description: description);
} else {
} else if (errorType == ErrorMethodResponse.serverFail) {
return ServerFailMethodResponse(description: description);
} else if (errorType == ErrorMethodResponse.cannotCalculateChanges) {
return CannotCalculateChangesMethodResponse(description: description);
} else {
return UndefinedErrorMethodResponse(errorType, description: description);
}
} catch (e) {
developer.log("_parsingErrorMethodResponse(): Exception $e");
Expand Down