Skip to content

Conversation

djkazic
Copy link
Contributor

@djkazic djkazic commented Oct 8, 2025

Upgrades lndinit to use the latest version of LND, v0.20.0-beta.rc1.

@djkazic djkazic requested review from bhandras and ziggie1984 October 8, 2025 12:43
@djkazic djkazic self-assigned this Oct 8, 2025
@djkazic
Copy link
Contributor Author

djkazic commented Oct 8, 2025

Going to fix up the CI.

@djkazic djkazic force-pushed the lnd-v0.20-0-beta.rc1 branch from eb64765 to 2ec4eee Compare October 8, 2025 14:08
@djkazic
Copy link
Contributor Author

djkazic commented Oct 8, 2025

@ziggie1984 it appears that func CompareRecords does not exist in sqldb v1.0.10: https://github.com/lightningnetwork/lnd/blob/sqldb/v1.0.10/sqldb/migrations.go

This does not trip up the LND build due to a replace: https://github.com/lightningnetwork/lnd/blob/90c96c7df1170a6e2f33386629a186266fc3b785/go.mod#L207

Should I do a replace in lndinit's go.mod as well?

@ziggie1984
Copy link
Contributor

so we need to tag the sqldb package on the lnd side I guess

@djkazic djkazic changed the title build: bump lnd to v0.20.0-beta.rc1 [HOLD] build: bump lnd to v0.20.0-beta.rc1 Oct 8, 2025
@ziggie1984
Copy link
Contributor

could we just use a hash for sqldb instead of a tag btw, just the current master hash, should work or ?

@djkazic
Copy link
Contributor Author

djkazic commented Oct 8, 2025

could we just use a hash for sqldb instead of a tag btw, just the current master hash, should work or ?

I'll try that.

Edit: that worked! go get github.com/lightningnetwork/lnd/sqldb@90c96c7df1170a6e2f33386629a186266fc3b785

@djkazic djkazic force-pushed the lnd-v0.20-0-beta.rc1 branch from 2ec4eee to 0fadd2d Compare October 8, 2025 14:23
Copy link
Contributor

@ziggie1984 ziggie1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djkazic djkazic merged commit 3626c13 into lightninglabs:main Oct 8, 2025
2 checks passed
@djkazic djkazic deleted the lnd-v0.20-0-beta.rc1 branch October 8, 2025 14:27
@djkazic djkazic changed the title [HOLD] build: bump lnd to v0.20.0-beta.rc1 build: bump lnd to v0.20.0-beta.rc1 Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants