epic: CuratedModule #558
Open
epic: CuratedModule #558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
## Description This resolves #560 An updated ET factory should be developed and deployed to support the proposed change ## Checklist - [x] Appropriate PR labels applied - [x] Test coverage maintained (`just coverage`) - [x] Tests are added/updated - [x] Documentation maintained - [x] No need to update
## Description Add a dedicated role that can change both manager and reward addresses. ## Checklist - [x] Appropriate PR labels applied - [x] Test coverage maintained (`just coverage`) - [ ] No need to add/update tests - [x] Tests are added/updated - [x] Documentation maintained - [x] No need to update - [ ] Updated
## Description - Moved all the csm tests into test/ModuleAbstract.t.sol and made them abstract - tons of renamings from CSM into Module - add (mostly) empty implementations for csm and curated suites setUps are the same now, copy-pasted as is but they'll most likely will be different ## Checklist - [x] Appropriate PR labels applied - [x] Test coverage maintained (`just coverage`) - [x] No need to add/update tests - [ ] Tests are added/updated - [x] Documentation maintained - [x] No need to update - [ ] Updated
## Description Set `targetLimit = 0` for uncompensated penalties (penalty > bond) and uncompensated EL Rewards Stealing Penalty. ## Checklist - [x] Appropriate PR labels applied - [x] Test coverage maintained (`just coverage`) - [x] Tests are added/updated - [x] Documentation maintained - [x] Updated --------- Co-authored-by: Sergey Khomutinin <[email protected]>
## Description Due to [CM v2 spec](https://hackmd.io/Y8_64-eKQiODGR1l5_Ux1A?view#Reserve-additional-bond)⚠️ **NOTE**: There is no `ValMart` notification about any changes in the reserve. ## Checklist - [x] Appropriate PR labels applied - [x] Test coverage maintained (`just coverage`) - [x] Tests are added/updated - [x] Documentation maintained - [x] No need to update
## Description Add built-in reward splitters. This change makes it easier to handle the allocation of the reward part to infra providers like Obol and SSV ## Checklist - [x] Appropriate PR labels applied - [x] Test coverage maintained (`just coverage`) - [x] Tests are added/updated - [x] Documentation maintained - [x] Updated
## Description Lock remaining amount after `burn` after lock settling on bond penalization. ## Checklist - [x] Appropriate PR labels applied - [x] Test coverage maintained (`just coverage`) - [x] Tests are added/updated - [x] Documentation maintained - [x] No need to update --------- Co-authored-by: Copilot <[email protected]>
…st/unit/abstract` `test/unit/lib` folders (#593) ## Description - `test/unit` is added and reflects `src` folder struct now - `CSAccounting.t.sol` is split to sub-contracts for readability ## Checklist - [X] Appropriate PR labels applied - [X] Test coverage maintained (`just coverage`) - [X] No need to add/update tests - [X] Documentation maintained - [X] No need to update
## Description This PR introduces support for permissionless proofs of validator withdrawal via a consolidation and implements a penalty multiplier system for exit penalties based on validator exit balance. ## Checklist - [x] Appropriate PR labels applied - [x] Test coverage maintained (`just coverage`) - [ ] No need to add/update tests - [x] Tests are added/updated - [x] Documentation maintained - [ ] No need to update - [x] Updated
## Description Main changes: - Added `_pendingSharesToSplit` to keep value to split on every pulling - It is not possible to set\change\remove splits when a node operator has pending shares to distribute or pending shares to split ## Checklist - [x] Appropriate PR labels applied - [x] Test coverage maintained (`just coverage`) - [x] Tests are added/updated - [x] Documentation maintained - [x] Updated --------- Co-authored-by: Dmitry Gusakov <[email protected]>
## Description - legacy queue and its migration - accounting feeDistributor getter ## Checklist - [x] Appropriate PR labels applied - [x] Test coverage maintained (`just coverage`) - [ ] No need to add/update tests - [x] Tests are added/updated - [x] Documentation maintained - [x] No need to update - [ ] Updated
## Description The introduced method acts a safety net for `submitWithdrawals` method. A proof of validator slashing should be delivered first to be able to report `slashingPenalty`. A separate role, `SUBMIT_WITHDRAWALS_ROLE`, was introduced to distinguish between different actors. This role will be granted to both `CSVerifier` and `EvmScriptExecutor`, while the `VERIFIER_ROLE` will be granted exclusively to `CSVerifier`. ## Checklist - [x] Appropriate PR labels applied - [x] Test coverage maintained (`just coverage`) - [ ] No need to add/update tests - [x] Tests are added/updated - [x] Documentation maintained - [ ] No need to update - [x] Updated
## Description Instead of burning the penalty for a delayed exit, the module now sends funds to the treasury in order to cover operational costs related to managing the delay, such as gas costs for proving the delay, communication with the node operator, etc. ## Checklist - [x] Appropriate PR labels applied - [x] Test coverage maintained (`just coverage`) - [ ] No need to add/update tests - [x] Tests are added/updated - [ ] Documentation maintained - [x] No need to update - [ ] Updated
## Description - Remove `withdrawableBlock` from consolidation function - Use structs as inputs for the rest of the CSVerifier functions - Use dynamic JavaScript modules instead of static JSON files for CSVerifier tests ## Checklist - [x] Appropriate PR labels applied - [x] Test coverage maintained (`just coverage`) - [ ] No need to add/update tests - [x] Tests are added/updated - [x] Documentation maintained - [x] No need to update - [ ] Updated
## Description Addresses the rest of comments in the #616 Renames the DelayPenalty to DelayFee ## Checklist - [x] Appropriate PR labels applied - [x] Test coverage maintained (`just coverage`) - [ ] No need to add/update tests - [x] Tests are added/updated - [x] Documentation maintained - [x] No need to update - [ ] Updated
## Description Remove ValMart-related code from CM/CSM ## Checklist - [x] Appropriate PR labels applied - [x] Test coverage maintained (`just coverage`) - [x] No need to add/update tests - [ ] Tests are added/updated - [x] Documentation maintained - [x] No need to update - [ ] Updated
## Checklist - [x] Appropriate PR labels applied - [x] Test coverage maintained (`just coverage`) - [x] No need to add/update tests - [x] Documentation maintained - [x] No need to update
## Description This PR fixes most of the remarks from https://hackmd.io/@bkovtun/B17sxcGhee ## Checklist - [x] Appropriate PR labels applied - [x] Test coverage maintained (`just coverage`) - [x] Tests are added/updated - [x] Documentation maintained - [x] Updated --------- Co-authored-by: skhomuti <[email protected]> Co-authored-by: Sergey Khomutinin <[email protected]>
## Description Adds the ability for the Node Operators to set a custom rewards claimer address. The address can initiate reward claims only. The rewards are still transferred to the `rewardAddress` ## Checklist - [x] Appropriate PR labels applied - [x] Test coverage maintained (`just coverage`) - [x] Tests are added/updated - [x] Documentation maintained - [x] Updated --------- Co-authored-by: Sergey Khomutinin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Curated Module version of CSM
Checklist
just coverage)