Add initial Eclipse attack simulation module with metrics collection #950

Fatumayattani · 2025-09-23T11:25:01Z

What was wrong?

This PR implements the initial setup for the Network Attack Simulation module in py-libp2p, as discussed in [[Discussion #929]] and tracked under Issue #57. The primary focus is on Eclipse attack simulation, building the test network, simulating malicious peers, and establishing the framework for network attack testing.

How was it fixed?

Added tests/security/attack_simulation/ submodule containing:

Eclipse attack:
- malicious_peer.py – Simulates malicious peer behavior
- network_builder.py – Builds test networks with honest and malicious nodes
- metrics_collector.py – Collects attack metrics during simulation
- attack_scenarios.py – Defines different Eclipse attack scenarios
- test_eclipse_simulation.py – Test suite validating network setup and malicious behavior
Utilities:
- Metrics calculation (attack_metrics.py)
- Network monitoring (network_monitor.py)
- Peer behavior simulation (peer_behavior_simulator.py)
- Tests for utilities
Configuration:
- attack_configs.py – Attack configuration options
- network_topologies.py – Predefined network topologies
Added README.md documenting module overview, structure, setup, usage, testing, metrics, roadmap, and Eclipse attack flow (Mermaid diagram)
All tests pass locally (6/6) confirming:
- Network setup works as expected
- Malicious peer behaviors execute correctly
- Metrics collection framework functions properly

To-Do

Clean up commit history if necessary
Add or update documentation related to these changes

Cute Animal Picture

…TLS docs

seetadev · 2025-09-23T15:40:27Z

@Fatumayattani : Thank you for opening the PR on eclipse attack simulation.

Great effort indeed. CCing @acul71, @yashksaini-coder, @bomanaps for their thoughts and feedback. This PR will indeed impact the py-libp2p library.

There is one CI/CD issue too, which is not related to your pull request.

I investigated it and documented it at #949 .

@yashksaini-coder , @sumanjeet0012 and @acul71 are fixing it. We will soon have all the CI/CD tests passing.

@Fatumayattani : Will re-run CI/CD pipeline once the issue is fixed today or tomorrow. In the meantime, assigning you more projects and issues on py-libp2p.

yashksaini-coder · 2025-09-23T19:45:35Z

@Fatumayattani can I get the access for this ?

Fatumayattani · 2025-09-24T06:27:55Z

Thank you @seetadev for the review and for coordinating on the CI/CD issue. I’ll re-run the checks once that’s resolved.

@yashksaini-coder I’ve added you as a collaborator so you now have access to the feature/attack-simulation branch. Please let me know if you face any issues or need anything else to get started.

Really appreciate everyone’s feedback and support in pushing this forward.

…ation files

yashksaini-coder · 2025-09-24T15:13:27Z

@Fatumayattani @seetadev Hi, I've reviewed the PR, and executed the checks and all tests on my end. Everything is good, all test cases passed ✔️ and some new changes to fix the linting and minor errors.

I will work on this for adding more attack simulation and review

…simulation

seetadev · 2025-09-24T17:55:25Z

@Fatumayattani , @yashksaini-coder : Wonderful, great to hear. Appreciate your efforts.

We will review this PR in detail. Re-ran the CI/CD pipeline.

Since, it is an important module addition, wish to have feedback first from @acul71 , @lla-dane and @sumanjeet0012 .

We will discuss with @pacrob and have his review after discussing in tomorrow's maintainer's call.

acul71

PR #950 Review: Eclipse Attack Simulation Module

Summary

This PR introduces a Network Attack Simulation module for py-libp2p with a well-designed dual-layer architecture for Eclipse attack testing.

Recommendation: ✅ APPROVE with mods

Implementation Analysis

✅ What's Working Well:

Dual-layer architecture - Simulation + Real integration
Real integration tests - 3/3 tests pass with actual libp2p hosts
Comprehensive framework - Well-structured attack simulation foundation
Test coverage - 9/9 tests pass (6 simulation + 3 real integration)

✅ Architecture Design:

Simulation Layer: Fast framework validation with placeholder metrics (by design)
Real Integration Layer: Comprehensive attack simulation with actual libp2p components

Current Assessment

Test Coverage: 100% (9/9 tests pass)
Code Quality: Excellent structure with real integration
Documentation: Comprehensive README with clear usage examples
Performance: Fast simulation (0.40s) + Real integration (2.06s)
Functionality: ✅ COMPLETE - Both layers working as designed

Final Recommendation

✅ APPROVE but answer questions
and also wait is there a newsfragment?

(venv) luca@r17:~/PNL_Launchpad_Curriculum/Libp2p/py-libp2p$ l newsfragments/57
ls: cannot access 'newsfragments/57': No such file or directory

acul71 · 2025-09-24T20:33:43Z

tests/security/attack_simulation/README.md

+1. [Metrics and Analysis](#metrics-and-analysis)
+1. [Roadmap](#roadmap)
+1. [Eclipse Attack Flow](#eclipse-attack-flow)
+1. [Contributing](#contributing)


Why are all this 1s here not 1,2,3,....

Just noticed the auto-tab completion

acul71 · 2025-09-24T20:34:59Z

tests/security/attack_simulation/config/attack_configs.py

+    "honest_nodes": 10,
+    "malicious_nodes": 3,
+    "attack_intensity": 0.5,
+}


Did you try with different settings? are them handled ?

Some logs with different settings?
You may want to open a discussion page, and only put a link here, to not over bloat the PR

I will try with different settings and have the screenshot of the results in the Discussion page for this.

@acul71 I have done some more attack simulation test with multiple configs, and new test suite, shared the new disucssion here, #960

…lation' into feature/attack-simulation

for improved clarity and maintainability

…tack simulation

…store result as json

Fatumayattani · 2025-09-26T07:15:19Z

Thanks everyone for the feedback and contributions.

I’ve added the missing newsfragment.

Kudos to @yashksaini-coder for running additional tests, and Discussion #960 contains the comprehensive Eclipse attack simulation results.

Special thanks to @acul71 for the detailed review and @seetadev for coordinating the CI/CD workflow. Really appreciate everyone’s collaboration and support on this.

acul71 · 2025-09-27T07:13:30Z

@seetadev @Fatumayattani @Fatumayattani @yashksaini-coder
Last thoughts here #960 (comment)

…ve tests

- Add new attack strategies and analysis - chore(attack_simulation): Update README

… issues

yashksaini-coder · 2025-09-27T13:06:57Z

Phase 2 implementation

Following the code review feedback from @acul71 I've implemented more attack simulation improvements and also ensured proper type safety and code quality:

Testing Improvements

Maintained comprehensive test coverage
Ensured all 52 tests passed successfully
Improved test readability and maintainability

Documentation

Updated docstrings for better clarity
Added explicit type hints where beneficial

Core Attack Implementations
✅ Connection Exhaustion Attack
✅ Protocol Attack Framework
✅ Flooding Attack System
✅ Sybil Attack Implementation
Analysis & Metrics
✅ Real-time Attack Metrics Collection
✅ Performance Impact Monitoring
Testing Infrastructure
✅ 52 Comprehensive Test Cases
✅ Multiple Scenario Testing

Requesting a code review and feedback from @seetadev @acul71

Updated.Attack.simulation.Test.runs.mp4

acul71 · 2025-09-28T04:08:10Z

Phase 2 implementation

Thanks @yashksaini-coder for your enthusiasms.
But before doing things right away, better have a talk.
I would like to hear from @Fatumayattani before proceeding since it's her PR.

seetadev · 2025-09-28T07:04:51Z

@Fatumayattani and @yashksaini-coder : Fantastic efforts and coordination. Appreciate it.

The roadmap looks neat. Appreciate the efforts and contribution. Keep up the good progress.

+1, completely agree with @acul71. Both you and @Fatumayattani can spearhead this very important PR towards phase 2 and towards a good conclusion. Looking forward to improving the security of py-libp2p with the collaborative efforts of our team.

Fatumayattani · 2025-09-28T11:30:53Z

Thanks again everyone for the great effort and collaboration so far. The progress on this module has been amazing to see.

I think it would be good for us to come up with a brief plan for what’s next so we can divide tasks clearly and keep communication open. That way we avoid overlapping work and make sure we’re all aligned as we move forward with the next phase.

Really appreciate all the energy and support from you @seetadev @acul71 @yashksaini-coder and I’m looking forward to continuing to build on this together.

pacrob · 2025-09-28T18:20:30Z

tests/security/attack_simulation/eclipse_attack/real_network_builder.py

+        honest_nodes: int = 3,  # Start smaller for testing
+        malicious_nodes: int = 1,


These args are never used. The function just returns one of each.

Updated the function to actually use honest_nodes and malicious_nodes parameters in loops

pacrob · 2025-09-28T18:30:57Z

tests/security/attack_simulation/eclipse_attack/test_multiple_scenarios.py

+    # Save summary report
+    summary_file = (
+        Path(__file__).parent.parent / "results" / "attack_summary_report.json"
+    )


Consider writing report files to either a temporary location outside the repo or to a location that is added to .gitignore. Running the tests as they are now leaves the repo dirty.

Add results directory location into .gitignore

pacrob · 2025-09-28T18:33:10Z

docs/tls-support.rst

+   from libp2p.security.tls.transport import TLSTransport
+
+   async def main():
+       host = await new_host(security_transports=[TLSTransport()])


new_host is not an async function. Please verify all your examples work as expected.

Remove the await keywords from the example code blocks.

…framework

…k tests

… hosts based on parameters

yashksaini-coder · 2025-09-30T04:44:13Z

@pacrob @seetadev Please review the new changes, I've addressed the review comments shared. No breaking changes occured or failure in tests.

Run the CI/CD pipeline to check the status

Fatumayattani · 2025-09-30T13:01:10Z

I’ve opened a new discussion to coordinate the next phase of the Network Attack Simulation module as we move into the extended attacks and libp2p/interop integration.

You can find it here: [Phase 2 Plan — Extended Attack Simulation Suite & Interop Integration]

It outlines the upcoming steps, responsibilities, and testing goals so we can stay aligned as we continue building this out together.

Thanks @seetadev @acul71 and @yashksaini-coder for the continued support and collaboration on this.

yashksaini-coder · 2025-09-30T13:55:24Z

@Fatumayattani There is a failing CI/CD let me work and fix it, before final review.

There are no failing test cases

yashksaini-coder · 2025-09-30T14:33:42Z

@seetadev @Fatumayattani @acul71 requesting a review now, please run the CI/CD pipeline

seetadev · 2025-09-30T18:32:59Z

@yashksaini-coder, @Fatumayattani : Re-ran the CI/Cd pipeline. All tests are passing. Had a discussion with @acul71. We will be sharing detailed feedback soon.

Appreciate your great efforts.

acul71 · 2025-10-04T05:23:03Z

@Fatumayattani @yashksaini-coder
Related: See ipcidr Protocol Usage in libp2p #976

Fatumayattani and others added 11 commits August 15, 2025 10:12

tls support

7a6b530

update tls docs

d0345b6

update tls support

7dd3469

update changes

bfbc389

tls support

a9b510e

tls support doc libp2p#700

6ea3016

Add tls-support.rst to docs toctree

77f4764

Merge branch 'main' into main

cc68f63

Replace asyncio with trio, fix newline, and run pre-commit checks on …

73d44ed

…TLS docs

Add initial Eclipse attack simulation module with tests

4f9eabe

Merge branch 'main' into feature/attack-simulation

d801a91

yashksaini-coder and others added 3 commits September 24, 2025 12:11

Merge branch 'libp2p:main' into feature/attack-simulation

c1df722

Merge branch 'main' into feature/attack-simulation

5691e6e

Refactor code for consistency and clarity; update README and configur…

6312c95

…ation files

Add real integration tests and metrics collection for Eclipse attack …

999d293

…simulation

acul71 approved these changes Sep 24, 2025

View reviewed changes

yashksaini-coder and others added 8 commits September 25, 2025 13:14

Merge branch 'main' into feature/attack-simulation

b46cdef

Linting errors resolved

44044f8

Merge remote-tracking branch 'refs/remotes/origin/feature/attack-simu…

efffe92

…lation' into feature/attack-simulation

Refactor real metrics collector and test structure

ba04a4f

for improved clarity and maintainability

Remove non-existent file

32483ac

Enhance type annotations and improve metrics collection in Eclipse at…

16708e3

…tack simulation

performed more test and test suite for multiple config scenarios and …

fd4d578

…store result as json

add newsfragment for PR libp2p#950 (Eclipse attack simulation module)

7004d94

Merge branch 'main' into feature/attack-simulation

e19929e

yashksaini-coder added 7 commits September 27, 2025 17:24

Add connection exhaustion attack implementation and tests passed

82531b1

Implement flooding attack module and corresponding tests

d9bd1b7

Add protocol attack implementation and tests

a3dfead

Add Sybil attacks and tests

c417fce

Add attack analysis framework and metrics collection with comprehensi…

0cd848c

…ve tests

Phase 2 completed:

7afdad7

- Add new attack strategies and analysis - chore(attack_simulation): Update README

Performed make fix & typecheck run to fix all linting and typechecker…

950b155

… issues

pacrob reviewed Sep 28, 2025

View reviewed changes

yashksaini-coder added 4 commits September 30, 2025 10:02

Remove obsolete attack simulation result files to streamline testing …

5ec1eec

…framework

Add results directory handling and update file paths in eclipse attac…

e9d3215

…k tests

Refactor real network builder to create multiple honest and malicious…

a1c8a31

… hosts based on parameters

Fix host initialization in TLS examples by removing unnecessary await

463f6ac

Update test to use a random port for address changes in DHT reissue test

a7b963e

yashksaini-coder and others added 2 commits October 4, 2025 12:20

Merge branch 'main' into feature/attack-simulation

587aa6f

Merge branch 'main' into feature/attack-simulation

6b3a421

		honest_nodes: int = 3, # Start smaller for testing
		malicious_nodes: int = 1,

Add initial Eclipse attack simulation module with metrics collection #950

Are you sure you want to change the base?

Add initial Eclipse attack simulation module with metrics collection #950

Conversation

Fatumayattani commented Sep 23, 2025

What was wrong?

How was it fixed?

To-Do

Cute Animal Picture

Uh oh!

seetadev commented Sep 23, 2025

Uh oh!

yashksaini-coder commented Sep 23, 2025

Uh oh!

Fatumayattani commented Sep 24, 2025

Uh oh!

yashksaini-coder commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

seetadev commented Sep 24, 2025

Uh oh!

acul71 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

PR #950 Review: Eclipse Attack Simulation Module

Summary

Implementation Analysis

✅ What's Working Well:

✅ Architecture Design:

Current Assessment

Final Recommendation

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Fatumayattani commented Sep 26, 2025

Uh oh!

acul71 commented Sep 27, 2025

Uh oh!

yashksaini-coder commented Sep 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Phase 2 implementation

Testing Improvements

Documentation

Uh oh!

acul71 commented Sep 28, 2025

Uh oh!

seetadev commented Sep 28, 2025

Uh oh!

Fatumayattani commented Sep 28, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yashksaini-coder commented Sep 30, 2025

Uh oh!

Fatumayattani commented Sep 30, 2025

Uh oh!

yashksaini-coder commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yashksaini-coder commented Sep 30, 2025

yashksaini-coder commented Sep 24, 2025 •

edited

Loading

acul71 left a comment •

edited

Loading

yashksaini-coder commented Sep 27, 2025 •

edited

Loading

yashksaini-coder commented Sep 30, 2025 •

edited

Loading

seetadev commented Sep 30, 2025 •

edited

Loading