Skip to content

feat: allow passing options to memoryAddrBook #3062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 25, 2024
Merged

feat: allow passing options to memoryAddrBook #3062

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1992262
chore: make mem addr book public
2color Nov 25, 2024
23f4fc7
fix: use correct default in factory
2color Nov 25, 2024
b74e107
feat: allow passing options to addr book factory
2color Nov 25, 2024
6bc70bf
Revert "chore: make mem addr book public"
2color Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions p2p/host/peerstore/pstoremem/addr_book.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ type memoryAddrBook struct {
var _ peerstore.AddrBook = (*memoryAddrBook)(nil)
var _ peerstore.CertifiedAddrBook = (*memoryAddrBook)(nil)

func NewAddrBook() *memoryAddrBook {
func NewAddrBook(opts ...AddrBookOption) *memoryAddrBook {
ctx, cancel := context.WithCancel(context.Background())

ab := &memoryAddrBook{
Expand All @@ -211,8 +211,12 @@ func NewAddrBook() *memoryAddrBook {
cancel: cancel,
clock: realclock{},
maxUnconnectedAddrs: defaultMaxUnconnectedAddrs,
maxSignedPeerRecords: defaultMaxUnconnectedAddrs,
maxSignedPeerRecords: defaultMaxSignedPeerRecords,
}
for _, opt := range opts {
opt(ab)
}

ab.refCount.Add(1)
go ab.background(ctx)
return ab
Expand Down
Loading