Skip to content

Conversation

@nisdas
Copy link
Contributor

@nisdas nisdas commented Feb 8, 2022

This is a follow up from #473.

When we rejoin a topic in a short duration, behavioural penalties can be triggered if we try to re-graft previously pruned peers. This is prevalent especially if we rejoin a topic before the prune backoff period ends.

  • When joining a topic, we make sure we do not graft peers who have a backoff assigned to them. This brings the method in line with the behaviour and peer filter that is applied in our heartbeat method.
  • Adds in a regression test for this particular case.

cc @vyzo

Copy link
Collaborator

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@vyzo vyzo merged commit aeb30a2 into libp2p:master Feb 8, 2022
@nisdas nisdas deleted the graftBetter branch March 3, 2022 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants