Skip to content

fix: avoid panic when peer is blacklisted after connection #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 19, 2021
Merged

fix: avoid panic when peer is blacklisted after connection #434

merged 2 commits into from
Jul 19, 2021

Conversation

@iand
Copy link
Contributor

@iand iand commented Jul 19, 2021

Fixes #426

vyzo
vyzo approved these changes Jul 19, 2021
View reviewed changes
Copy link
Collaborator

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we avoid the newline changes? other than that, LGTM.

@iand
Copy link
Contributor Author

iand commented Jul 19, 2021

can we avoid the newline changes? other than that, LGTM.

Done. PTAL.

@vyzo vyzo merged commit 37ebe34 into libp2p:master Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vyzo vyzo vyzo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Panic when using WithBlacklist option

2 participants

@iand @vyzo