Fix close of closed channel #427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happens when there are multiple subscriptions to a topic and a single subscription is canceled twice.
vyzo
requested changes
Jun 14, 2021
subscription.go
Outdated
Comment on lines
47
to
50
| if !sub.closed { | ||
| close(sub.ch) | ||
| sub.closed = true | ||
| } |
There was a problem hiding this comment.
this needs to be atomic or we can have two concurrent closes fail; can you make this an swap/compare with an atomic variable?
There was a problem hiding this comment.
Looked like close is never called concurrently; only called by the handler goroutine. ...but in case it is someday...
vyzo
approved these changes
Jun 15, 2021
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens when there are multiple subscriptions to a topic and a single subscription is canceled twice.
FIxes #425