implement synchronous validation for locally published messages #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that locally published messages are never dropped because of full validation queues.
|
I also temporarily disabled the flaky delivery tag tracer test -- it's getting on my nerves. Follow up issue: #407 |
Stebalien
reviewed
Mar 24, 2021
Stebalien
reviewed
Mar 24, 2021
Stebalien
approved these changes
Mar 31, 2021
| // ValidationError is an error that may be signalled from message publication when the message | ||
| // fails validation | ||
| type ValidationError struct { | ||
| Reason string |
There was a problem hiding this comment.
Nit: the nice way to do this is to make this "Reason" an error as well and expose it via Cause(). That way, one can check xerrors.Is(error, ValidationError{}) and xerrors.Is(error, UltimateCause{}).
There was a problem hiding this comment.
In principle this is indeed quite nice, but it's quite likely unnecessary -- the Reason strings are exported and part of the public API for tracers.
We could add named errors for all of them but this seems more work than what is worth right now.
If you feel strongly about it, let's make an issue to address it.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that locally published messages are never dropped because of full validation queues.
Closes #398