Fix volume expansion #196
Merged
Fix volume expansion #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrak
added a commit
that referenced
this pull request
Jul 22, 2025
Project ID was not considered in ExpandVolume(). The expandVolume API doesnt have a projectID parameter so we need to fetch the volume before calling ExpandVolume --------- Co-authored-by: hrak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Volume expansion function called c.volume.getVolumebyId() that results in no volume found, this caused volume expansion failure. The reason is to find volume, cloudstack API require projectID.
Fix:
The fix is to use the volume returned by the native getVolumebyId() function that passed the projectID to the cloudstack API call.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.