feat: Use SA for node daemonset in deploy manifest and other improvem… #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hrak
commented
Jul 2, 2024
hrak
commented
- Use service account for node daemonset
- Add volume/volumemount (commented) for Ignition support
- improve securitycontext across the board
- Added affinity
- Changed the node-driver-registrar livenessprobe as documented in CSI node driver registrar project
hrak
force-pushed
the
node_sa_deploy_manifest
branch
from
9e7e8cb to
ba26d27
Compare
kasperhendriks
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.