Windows should no longer pause by default #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he vanilla behaviour
|
If you want to get this merged please make sure that our guis are checked that both values are fine. Especially the ones without background image might need lightboxes. More like i'm probably fine with pause = false by default, not sure about the lightbox. |
|
I've double checked all of the GUIs in Minecolonies, kept the lightboxes where still appropriate (very few UI's remaining that need it). The rest the lightbox properties have been removed in waiting for this. Structurize still has the lightbox properties set on all GUI's, so this will not affect Structurize. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To mirror vanilla GUI's (and in support of ldtteam/minecolonies#10675) the pause behaviour should be off by default, as nearly none of the vanilla GUI's actually pause the screen, besides the escape menu.