destroyPlayer() does not remove player in cache

[zvyap]

After looking at the source code of the lavalink-client, the LavalinkPlayer should be remove from cache after calling destoryPlayer() method

But it don't.

Source code

[duncte123]

Please don't use the weirdly named methods. You're supposed to use getPlayer() as that will check the cache first

[zvyap]

Please don't use the weirdly named methods. You're supposed to use getPlayer() as that will check the cache first

I don't want it to create a new player as getPlayer() will create a new player if the cache is not exist
Why I want to create a new player if I already want to destory the player if exist.....

[duncte123]

Please don't use the weirdly named methods. You're supposed to use getPlayer() as that will check the cache first

I don't want it to create a new player as getPlayer() will create a new player if the cache is not exist Why I want to create a new player if I already want to destory the player if exist.....

Then there seems to be a flaw in your code. If you just want to destroy the player, there is no need to check if it exists.
Also, if you are using the JDA or D4J integration, the player will be automatically destroyed when your bot leaves the voice channel

[zvyap]

Please don't use the weirdly named methods. You're supposed to use getPlayer() as that will check the cache first

I don't want it to create a new player as getPlayer() will create a new player if the cache is not exist Why I want to create a new player if I already want to destory the player if exist.....

Then there seems to be a flaw in your code. If you just want to destroy the player, there is no need to check if it exists. Also, if you are using the JDA or D4J integration, the player will be automatically destroyed when your bot leaves the voice channel

Im not using either JDA or D4J, Im making a global service handling all of my track stuff (Web controller/Bot/Other)

Im doing the check because I want to know if the player is exist previously, if Im using node.destroyPlayer(), I will not know that.
It also send a destroy rest action which it add extra latency to my service.

[duncte123]

You can always check the connected status on the link. If it is connected, you have a player. Also, if you call subscribe() instead of block() te request will be done asynchronously, meaning that there is no added latency

[zvyap]

Also, if you call subscribe() instead of block() te request will be done asynchronously, meaning that there is no added latency

Although I use subscribe() it still technically add latency to my service response, I need to wait the response came in to be able to response to my client

You can always check the connected status on the link. If it is connected, you have a player.

This is not the case, if lavalink-client receive DISCONNECT state from Lavalink server, the player still exist
Same as the Lavalink server, if the voice connection got DISCONNECTED, the player still exist, the track still playing at the background

What Im doing is destroy the player, as I do this, the connection to the Discord voice server also will end

[duncte123]

Either way, this was fixed in version 2.2.0