fix: base class guard in return types is breaking custom guards #56779
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phadaphunk
changed the title
crynobone
approved these changes
Aug 27, 2025
|
Related issue #56783 |
|
At this point, isn't it better to revert #56684 altogether? |
|
@rodrigopedra I don't think the typing is bad, but some of them definitely needed a bit more attention. |
|
I also don't think it's bad. But it seems better, due to the repeated issues since its release, to target it to master and ask the community to review it extensively before releasing those changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newly added strict types are causing issues with popular packages like jwt-auth since the custom Guard implements the Guard contract (parent).
I feel the return type is too strict. I don't think the return type should be
mixedbut shouldn't it at least be Guard and not StatefulGuard. This way custom guard implementations are not breaking.With 11.5k ⭐ on
jwt-auth, I'm surprised no one got this issue today.