-
Notifications
You must be signed in to change notification settings - Fork 11.5k
[12.x] chore: remove redundant phpdocs #56775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 12.x
Are you sure you want to change the base?
Conversation
I'm tired, boss |
bc20bdf
to
c1a5462
Compare
0a19556
to
83c0f81
Compare
Full strict typing in v13! 🤣 |
These are not redundant/superfluous, so Pint did not remove any of these. If you're referring to adding more native types then yes, we should keep any tags that are not redundant and add information that can't be expressed by native types alone like array shapes, generics, conditional returns, etc. |
I'm not doing any of this on 12.x I don't think. |
I can target |
Hello!
Motivation
The contribution guidelines say to remove redundant tags that provide no additional information over native php types (note that this does not include tags that provide additional information such as descriptions or generics):
However, as can be seen by this PR, there are over 6,500 redundant tags in this codebase that are not needed and can be cleaned up. This PR adds the
no_superflous_phpdoc_tags
rule to the pint config to help enforce the contribution guidelines and clean up the redundant tags.Removing redundant tags:
Review
Here's a breakdown of the commits:
event
helper so that the phpdocs are not detected as unused and removedThanks!