[13.x] use clearer pagination view names #56307
Open
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's been a LONG time since Bootstrap 3 was the default pagination view, but it looks like their file names persisted. we'll update the view file names to explicitly describe them as the Bootstrap 3 views. this will help avoid confusion since Tailwind is our default now.
|
Maybe |
I'd even say we just drop it and force people to be explicit, rather than making an assumption for them. |
|
@taylorotwell was this marked as draft because of the pipeline issues? or something you'd like changed? |
|
marking as "ready for review" under the assumption it was moved to "draft" because of the pipeline issues. lmk if that's not the case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's been a LONG time since Bootstrap 3 was the default pagination view, but it looks like their file names persisted. we'll update the view file names to explicitly describe them as the Bootstrap 3 views.
this will help avoid confusion since Tailwind is our default now.
resubmission of #56297