Add CPU Usage monitor #40
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Introduce `stat:cpu` command and monitor + Document `stat:cpu` + Add CpuUsage model and table `cpu_usage` + Add CPU statistics class to sample and test the statistic
|
I'd like to get #35 merged first and then introduce additional monitors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Linux systems, as used by Forge, the load average is a diminishing average calculation based on processes running, ready to run, waiting for IO and uninterruptable processes. For this reason, we cannot compute CPU load based on Load Average.
Instead, we should rebrand CPU Load to System Load, and introduce a new type of monitor: CPU Usage.
The proposed monitor uses
/proc/statto find the aggregated, kernel-written, CPU statistics for all cores in the system, basically calculates Idle Time as a percentage, and then uses that to derive the opposite value: CPU Usage. (This works intuitively the same way as what Windows OS does in the Task Manager).Following changes are made:
stat:cpucommand and monitorstat:cpuand rebrandstat:cpu_loadfrom "CPU Load" to "System Load"cpu_usage