-
Notifications
You must be signed in to change notification settings - Fork 19.4k
feat(mistralai): remove tenacity retries for embeddings #33491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(mistralai): remove tenacity retries for embeddings #33491
Conversation
CodSpeed Performance ReportMerging #33491 will not alter performanceComparing Summary
Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noeliecarbo thanks for the contribution!
This is a breaking change, but it's not clear to me what users gain from it. What kind of customization would they want to do that's meaningful in practice from what they can already do?
@eyurtsev Thanks for the feedback! From my perspective, I see the following benefits:
|
what happens if you set max_retries = 0? |
@eyurtsev if I set max_retries=0, then no retries are performed. However, a tenacity.RetryError is still returned, which makes it more difficult to catch specific errors and debug the code in general |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we enable users to opt-out of the retries for now? e.g., make max_retries
and wait_time
int | None
with existing int defaults.
a3e0593
to
aa48b38
Compare
I like the idea and added a commit |
MistralAI (and embeddings in particular) is the only package that uses tenacity retries.
This PR removes them, offering the following benefits: