Skip to content

Add share link #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Mar 19, 2024
Merged

Add share link #42

merged 13 commits into from
Mar 19, 2024

Conversation

eyurtsev
Copy link
Collaborator

@eyurtsev eyurtsev commented Mar 18, 2024 •
edited
Loading

  • This adds a share link on the UI
  • Supports loading a shared extractor, but not using it yet (requires a change on the backend)
  • Fixes API endpoint for fetching extractor information

@eyurtsev eyurtsev changed the title WIP: Add share link Add share link Mar 19, 2024
eyurtsev
eyurtsev commented Mar 19, 2024
View reviewed changes
frontend/app/components/Playground.tsx
<Button type="submit" disabled={isDisabled}>
Run
</Button>
{isShared ? (
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will implement in a follow up PR. Requires a separate change on the backend. Doesn't break any current functionality

@eyurtsev eyurtsev requested a review from bracesproul March 19, 2024 20:16
@eyurtsev
Copy link
Collaborator Author

#40

bracesproul
bracesproul approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@bracesproul bracesproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple nits, otherwise lgtm!

@eyurtsev
Copy link
Collaborator Author

thanks for review!

@eyurtsev eyurtsev merged commit ac7f43b into main Mar 19, 2024
@eyurtsev eyurtsev deleted the eugene/update_menu branch March 19, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bracesproul bracesproul bracesproul approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eyurtsev @bracesproul