Skip to content

Conversation

@PengyuanZhao
Copy link
Contributor

@PengyuanZhao PengyuanZhao commented Apr 4, 2025

Summary

  • Fix roles when folders_to_include is set
  • Remove roles/resourcemanager.organizationViewer. It's permission is already covered by roles/browse
  • Add dependencies for lacework_integration_gcp_cfg
  • Clean up code

How did you test this change?

Run

provider "google" {}

provider "lacework" {}

module "gcp_organization_level_config" {
  source = "../../"

  org_integration = true
  organization_id = "121868925203"
  project_id      = "abc-demo-project-123"

  folders_to_exclude = ["folders/561670468574"]
}

Integration completes successfully:

Screenshot 2025-04-03 at 8 09 58 PM

@PengyuanZhao PengyuanZhao requested a review from a team as a code owner April 4, 2025 17:35
@PengyuanZhao PengyuanZhao requested review from aneesh-mysore, charanbir and thekeys93 and removed request for a team April 4, 2025 17:35
@PengyuanZhao PengyuanZhao merged commit 1ba6a68 into main Apr 7, 2025
9 checks passed
@PengyuanZhao PengyuanZhao deleted the pengyuan/LINK-3663 branch April 7, 2025 16:19
@lacework-releng lacework-releng mentioned this pull request Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants