Skip to content

Cover case when flag has empty (not nil) default value #2609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 29, 2025
Merged

Cover case when flag has empty (not nil) default value #2609

merged 2 commits into from
Sep 29, 2025

Conversation

@pPrecel
Copy link
Contributor

@pPrecel pPrecel commented Sep 26, 2025

Description

Changes proposed in this pull request:

  • interpret flag with empty default as its true value
  • interpret flag with null default as flag without default value

Related issue(s)

@pPrecel pPrecel requested a review from a team as a code owner September 26, 2025 10:12
@pPrecel pPrecel added the kind/bug Categorizes issue or PR as related to a bug. label Sep 26, 2025
@pPrecel pPrecel enabled auto-merge (squash) September 26, 2025 10:12
@pPrecel pPrecel force-pushed the fix-null-flag-default branch from 54090b3 to 3ce4035 Compare September 29, 2025 08:26
@pPrecel pPrecel merged commit 53d6b1f into kyma-project:main Sep 29, 2025
10 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Oct 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Cortey Cortey Cortey approved these changes

Assignees

@Cortey Cortey

Labels

kind/bug Categorizes issue or PR as related to a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pPrecel @Cortey