Skip to content

ContainerRestartRules is beta now #52935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: dev-1.35
Choose a base branch
from
Open

ContainerRestartRules is beta now #52935

wants to merge 1 commit into from
+8 −5

Conversation

@SergeyKanzhelev
Copy link
Member

@k8s-ci-robot k8s-ci-robot added this to the 1.35 milestone Oct 24, 2025
@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Oct 24, 2025
@netlify
Copy link

netlify bot commented Oct 24, 2025 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit edea161
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-vnext-staging/deploys/68fbed42b7be5e0008d7538f

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Oct 24, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tengqm for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 24, 2025
@SergeyKanzhelev SergeyKanzhelev mentioned this pull request Oct 24, 2025
Open
12 tasks
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 24, 2025
@netlify
Copy link

netlify bot commented Oct 24, 2025

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 0adecd0
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/68fbece0b2503f00088b934a
😎 Deploy Preview https://deploy-preview-52935--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Oct 24, 2025

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit edea161
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/68fbed4286665d000833316e
😎 Deploy Preview https://deploy-preview-52935--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

lmktfy
lmktfy reviewed Oct 28, 2025
View reviewed changes
content/en/docs/reference/command-line-tools-reference/feature-gates/ContainerRestartRules.md
- stage: alpha
defaultValue: false
fromVersion: "1.34"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heya, this needs a tweak.

Suggested change
toVersion: "1.34"

content/en/docs/concepts/workloads/pods/pod-lifecycle.md
has its container-level `restartPolicy` set to `Always`, and does not support `restartPolicyRules`.

The container restarts will follow the same exponential backoff as pod restart policy described above.
Supported container restart policies:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: it'd be nice to swap these so that they are a description list.

Not required, but recommended; when features go enabled-by-default, we prefer the docs to be GA quality at that point.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, see #52971

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmktfy lmktfy lmktfy left review comments

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

@tengqm tengqm Awaiting requested review from tengqm

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

SIG Node: code and documentation PRs
Status: Triage

Milestone

1.35

Development

Successfully merging this pull request may close these issues.

3 participants

@SergeyKanzhelev @k8s-ci-robot @lmktfy