Skip to content

Conversation

g-gaston
Copy link
Contributor

@g-gaston g-gaston commented Aug 1, 2025

This runs all the e2e tests for on-by-default features against a cluster with kubelet server certificates signed by the CP (as opposed to the default self-signed). This way we make sure we exercise certificate validation on any test making exec/logs/port-forward requests.

I tested this locally (with pj on kind) and I got all tests passing except a few ones using volumes. I suspect this is because I'm running "prow" inside a kind cluster and not because of the job's code. I got the same failures when running ci-kubernetes-e2e-kind locally.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 1, 2025
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 1, 2025
@enj enj added this to SIG Auth Aug 2, 2025
@enj enj moved this to Needs Triage in SIG Auth Aug 2, 2025
@aramase aramase moved this from Needs Triage to In Review in SIG Auth Aug 4, 2025
@aramase
Copy link
Member

aramase commented Aug 4, 2025

/triage accepted
/assign

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Aug 4, 2025
@g-gaston g-gaston force-pushed the ci-periodic-job-kubelet-server-certs branch from b367422 to 65e25b4 Compare August 5, 2025 14:17
@g-gaston g-gaston force-pushed the ci-periodic-job-kubelet-server-certs branch from 65e25b4 to 8735d2f Compare August 6, 2025 13:42
@k8s-ci-robot k8s-ci-robot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 6, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: g-gaston
Once this PR has been reviewed and has the lgtm label, please assign liggitt, wojtek-t for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/testgrid labels Aug 6, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these changes should be in a separate PR. I've opened #35364.

- org: kubernetes
repo: test-infra
base_ref: master
path_alias: "k8s.io/test-infra"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
path_alias: "k8s.io/test-infra"
path_alias: k8s.io/test-infra

nit

Comment on lines +14 to +17
- org: kubernetes
repo: kubernetes
base_ref: master
path_alias: k8s.io/kubernetes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be set as workdir?

Suggested change
- org: kubernetes
repo: kubernetes
base_ref: master
path_alias: k8s.io/kubernetes
- org: kubernetes
repo: kubernetes
base_ref: master
path_alias: k8s.io/kubernetes
workdir: true

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 21, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config Issues or PRs related to code in /config area/jobs area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

4 participants