-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Add periodic job for signed kubelet serving certs #35255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add periodic job for signed kubelet serving certs #35255
Conversation
/triage accepted |
config/jobs/kubernetes/sig-auth/signed-kubelet-server-certs.yaml
Outdated
Show resolved
Hide resolved
b367422
to
65e25b4
Compare
65e25b4
to
8735d2f
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: g-gaston The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these changes should be in a separate PR. I've opened #35364.
- org: kubernetes | ||
repo: test-infra | ||
base_ref: master | ||
path_alias: "k8s.io/test-infra" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
path_alias: "k8s.io/test-infra" | |
path_alias: k8s.io/test-infra |
nit
- org: kubernetes | ||
repo: kubernetes | ||
base_ref: master | ||
path_alias: k8s.io/kubernetes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs to be set as workdir?
- org: kubernetes | |
repo: kubernetes | |
base_ref: master | |
path_alias: k8s.io/kubernetes | |
- org: kubernetes | |
repo: kubernetes | |
base_ref: master | |
path_alias: k8s.io/kubernetes | |
workdir: true |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This runs all the e2e tests for on-by-default features against a cluster with kubelet server certificates signed by the CP (as opposed to the default self-signed). This way we make sure we exercise certificate validation on any test making exec/logs/port-forward requests.
I tested this locally (with pj on kind) and I got all tests passing except a few ones using volumes. I suspect this is because I'm running "prow" inside a kind cluster and not because of the job's code. I got the same failures when running
ci-kubernetes-e2e-kind
locally.