Skip to content

Conversation

xcarolan
Copy link
Contributor

fixes #19789

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 18, 2025
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@medyagh
Copy link
Member

medyagh commented Jan 22, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 22, 2025
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20288) |
+----------------+----------+---------------------+
| minikube start | 50.6s    | 51.7s               |
| enable ingress | 16.7s    | 16.1s               |
+----------------+----------+---------------------+

Times for minikube start: 52.2s 51.3s 48.2s 50.0s 51.1s
Times for minikube (PR 20288) start: 53.2s 49.7s 53.5s 51.4s 50.8s

Times for minikube ingress: 18.6s 16.0s 19.0s 15.0s 15.0s
Times for minikube (PR 20288) ingress: 16.5s 15.5s 18.5s 15.0s 15.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20288) |
+----------------+----------+---------------------+
| minikube start | 21.8s    | 23.1s               |
| enable ingress | 12.6s    | 12.6s               |
+----------------+----------+---------------------+

Times for minikube start: 21.2s 21.3s 21.7s 20.5s 24.3s
Times for minikube (PR 20288) start: 21.4s 23.8s 21.8s 24.3s 24.3s

Times for minikube ingress: 12.8s 12.3s 12.8s 12.8s 12.3s
Times for minikube (PR 20288) ingress: 12.8s 12.8s 12.3s 12.8s 12.3s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20288) |
+----------------+----------+---------------------+
| minikube start | 21.0s    | 21.0s               |
| enable ingress | 22.9s    | 23.0s               |
+----------------+----------+---------------------+

Times for minikube ingress: 22.8s 22.8s 22.8s 22.8s 23.3s
Times for minikube (PR 20288) ingress: 22.8s 23.3s 22.8s 22.8s 23.2s

Times for minikube start: 22.9s 19.5s 20.8s 21.0s 20.9s
Times for minikube (PR 20288) start: 19.4s 22.8s 22.9s 19.8s 20.0s

@minikube-pr-bot
Copy link

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment Test Name Flake Rate
Docker_Linux_crio (6 failed) TestAddons/Setup(gopogh) 2.17% (chart)
Docker_Linux_crio (6 failed) TestStartStop/group/default-k8s-diff-port/serial/Pause(gopogh) 8.89% (chart)
Docker_Linux_crio (6 failed) TestFunctional/parallel/MySQL(gopogh) 39.13% (chart)
Docker_Linux_crio (6 failed) TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup(gopogh) 39.13% (chart)
Docker_Linux_crio (6 failed) TestFunctional/parallel/TunnelCmd/serial/AccessDirect(gopogh) 39.13% (chart)
Docker_Linux_crio (6 failed) TestFunctional/parallel/PersistentVolumeClaim(gopogh) 43.48% (chart)
KVM_Linux_containerd (3 failed) TestPreload(gopogh) 0.00% (chart)
KVM_Linux_containerd (3 failed) TestStartStop/group/default-k8s-diff-port/serial/FirstStart(gopogh) 2.04% (chart)

Besides the following environments also have failed tests:

  • KVM_Linux_crio: 11 failed (gopogh)

  • Docker_Linux_containerd_arm64: 1 failed (gopogh)

  • Docker_Linux_crio_arm64: 1 failed (gopogh)

To see the flake rates of all tests by environment, click here.

@xcarolan
Copy link
Contributor Author

@medyagh - I don't think these are valid error - are there issues with Jenkins?

Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the failure looks like flake

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ComradeProgrammer, medyagh, xcarolan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ComradeProgrammer,medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ComradeProgrammer ComradeProgrammer merged commit 262895b into kubernetes:master Apr 24, 2025
36 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9P detecting logic blocking when 9P is present
6 participants