Graduate JobReadyPods to beta #107476

alculquicondor · 2022-01-11T19:27:21Z

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

Graduate JobReadyPods to beta.

Set the podUpdateBatchPeriod to 1s (kubernetes/enhancements#3249).

When the feature is enabled, the field .status.ready track the number of ready pods in a Job.

/sig apps

Which issue(s) this PR fixes:

Part of kubernetes/enhancements#2879

Special notes for your reviewer:

Does this PR introduce a user-facing change?

JobReadyPods graduates to Beta and it's enabled by default.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: git.k8s.io/enhancements/keps/sig-apps/2879-ready-pods-job-status
- [Usage]: https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/job-v1/#JobStatus

k8s-triage-robot · 2022-01-11T19:45:57Z

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

leilajal · 2022-03-17T16:32:35Z

/triage accepted
/remove-sig api-machinery

alculquicondor · 2022-03-17T20:46:24Z

/retest

alculquicondor · 2022-03-22T13:46:10Z

/label api-review

liggitt · 2022-03-28T18:25:14Z

@lavalamp per https://github.com/kubernetes/kubernetes/blob/master/OWNERS_ALIASES#L332-L335

lavalamp · 2022-03-28T21:37:26Z

pkg/features/kube_features.go

I thought we were no longer defaulting beta features on?

beta endpoints, to start, since that is what causes 99% of user pain.

policy for beta fields hasn't changed, since they have proven far less disruptive.

lavalamp · 2022-03-28T21:41:26Z

/approve

k8s-triage-robot · 2022-03-29T01:37:10Z

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

The PR does have any do-not-merge/* labels
The PR does not have the needs-ok-to-test label
The PR is mergeable (does not have a needs-rebase label)
The PR is approved (has cncf-cla: yes, lgtm, approved labels)
The PR is failing tests required for merge

You can:

Review the full test history for this PR
Prevent this bot from retesting with /lgtm cancel or /hold
Help make our tests less flaky by following our Flaky Tests Guide

/retest

pacoxu · 2022-03-29T03:18:15Z

/test pull-kubernetes-integration

pacoxu · 2022-03-29T05:32:39Z

/test pull-kubernetes-integration

pacoxu · 2022-03-29T08:11:05Z

/test pull-kubernetes-integration

k8s-triage-robot · 2022-03-29T10:59:11Z

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

The PR does have any do-not-merge/* labels
The PR does not have the needs-ok-to-test label
The PR is mergeable (does not have a needs-rebase label)
The PR is approved (has cncf-cla: yes, lgtm, approved labels)
The PR is failing tests required for merge

You can:

Review the full test history for this PR
Prevent this bot from retesting with /lgtm cancel or /hold
Help make our tests less flaky by following our Flaky Tests Guide

/retest

k8s-triage-robot · 2022-03-29T13:59:11Z

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

The PR does have any do-not-merge/* labels
The PR does not have the needs-ok-to-test label
The PR is mergeable (does not have a needs-rebase label)
The PR is approved (has cncf-cla: yes, lgtm, approved labels)
The PR is failing tests required for merge

You can:

Review the full test history for this PR
Prevent this bot from retesting with /lgtm cancel or /hold
Help make our tests less flaky by following our Flaky Tests Guide

/retest

Set podUpdateBatchPeriod to 1s Change-Id: I8a10fd8f8559adad9df179b664b8c82851607855

alculquicondor · 2022-03-29T14:08:49Z

Fixed the integration test (since it was a new test, it didn't have the .status.ready fields set)

alculquicondor · 2022-03-29T14:44:04Z

/retest

soltysh

/lgtm

soltysh · 2022-03-29T15:51:35Z

/test pull-kubernetes-node-e2e-containerd

k8s-ci-robot · 2022-03-29T15:51:56Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, lavalamp, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~api/OWNERS~~ [lavalamp]
~~pkg/apis/OWNERS~~ [lavalamp]
~~pkg/controller/job/OWNERS~~ [lavalamp,soltysh]
~~pkg/features/OWNERS~~ [lavalamp,soltysh]
~~pkg/generated/openapi/OWNERS~~ [lavalamp]
~~staging/src/k8s.io/api/OWNERS~~ [lavalamp]
~~test/OWNERS~~ [lavalamp,soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

soltysh · 2022-03-29T16:14:05Z

/test pull-kubernetes-e2e-gce-100-performance

soltysh · 2022-03-29T16:23:59Z

/test pull-kubernetes-e2e-gce-ubuntu-containerd

soltysh · 2022-03-29T16:34:10Z

/milestone v1.24

k8s-ci-robot requested review from smarterclayton and thockin January 11, 2022 19:27

alculquicondor force-pushed the job-ready branch from 614aa48 to 96bffab Compare January 12, 2022 14:28

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 12, 2022

alculquicondor force-pushed the job-ready branch from 96bffab to 852adca Compare January 12, 2022 17:21

alculquicondor mentioned this pull request Jan 24, 2022

Track Ready Pods in Job status kubernetes/enhancements#2879

Closed

14 tasks

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 18, 2022

alculquicondor force-pushed the job-ready branch from 852adca to 25777ca Compare March 16, 2022 15:21

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 16, 2022

alculquicondor force-pushed the job-ready branch from 25777ca to cf940e7 Compare March 16, 2022 17:55

k8s-ci-robot added area/code-generation sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Mar 16, 2022

k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 17, 2022

alculquicondor force-pushed the job-ready branch from cf940e7 to ecafef2 Compare March 21, 2022 17:41

k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 22, 2022

k8s-ci-robot added the api-review Categorizes an issue or PR as actively needing an API review. label Mar 22, 2022

liggitt assigned lavalamp Mar 28, 2022

lavalamp reviewed Mar 28, 2022

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2022

Graduate JobReadyPods to beta

8c00f51

Set podUpdateBatchPeriod to 1s Change-Id: I8a10fd8f8559adad9df179b664b8c82851607855

alculquicondor force-pushed the job-ready branch from ecafef2 to 8c00f51 Compare March 29, 2022 14:07

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2022

soltysh approved these changes Mar 29, 2022

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2022

k8s-ci-robot added this to the v1.24 milestone Mar 29, 2022

k8s-ci-robot merged commit dd1e433 into kubernetes:master Mar 29, 2022

github-actions bot mentioned this pull request Apr 5, 2022

Week Ending April 3, 2022 dev-obs/actus#414

Open

Graduate JobReadyPods to beta #107476

Graduate JobReadyPods to beta #107476

Uh oh!

Conversation

alculquicondor commented Jan 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Uh oh!

k8s-triage-robot commented Jan 11, 2022

Uh oh!

leilajal commented Mar 17, 2022

Uh oh!

alculquicondor commented Mar 17, 2022

Uh oh!

alculquicondor commented Mar 22, 2022

Uh oh!

liggitt commented Mar 28, 2022

Uh oh!

lavalamp Mar 28, 2022

Choose a reason for hiding this comment

Uh oh!

liggitt Mar 28, 2022

Choose a reason for hiding this comment

Uh oh!

lavalamp Mar 28, 2022

Choose a reason for hiding this comment

Uh oh!

lavalamp commented Mar 28, 2022

Uh oh!

k8s-triage-robot commented Mar 29, 2022

Uh oh!

pacoxu commented Mar 29, 2022

Uh oh!

pacoxu commented Mar 29, 2022

Uh oh!

pacoxu commented Mar 29, 2022

Uh oh!

k8s-triage-robot commented Mar 29, 2022

Uh oh!

k8s-triage-robot commented Mar 29, 2022

Uh oh!

alculquicondor commented Mar 29, 2022

Uh oh!

alculquicondor commented Mar 29, 2022

Uh oh!

soltysh left a comment

Choose a reason for hiding this comment

Uh oh!

soltysh commented Mar 29, 2022

Uh oh!

k8s-ci-robot commented Mar 29, 2022

Uh oh!

soltysh commented Mar 29, 2022

Uh oh!

soltysh commented Mar 29, 2022

Uh oh!

soltysh commented Mar 29, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

alculquicondor commented Jan 11, 2022 •

edited

Loading