Skip to content

Apply CPU startup boost in admission controller if its set #8458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: experimental-cpu-boost
Choose a base branch
from
Open

Apply CPU startup boost in admission controller if its set #8458

wants to merge 1 commit into from
+513 −9

Conversation

kamarabbas99
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Introduces changes in the admission-controller component to apply cpu startup boost if its set in the vpa spec.
Also the original cpu request is added in annotation so it can be applied back again in updater if the duration has passed.

Special notes for your reviewer:

Depends on #8417
Will rebase once that is merged.

Does this PR introduce a user-facing change?

Users can now configure a startupBoost policy in the VPA spec.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: (https://github.com/kubernetes/autoscaler/tree/master/vertical-pod-autoscaler/enhancements/7862-cpu-startup-boost#aep-7862-cpu-startup-boost)

@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area labels Aug 18, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kamarabbas99
Once this PR has been reviewed and has the lgtm label, please assign adrianmoisey for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @kamarabbas99. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/needs-area labels Aug 18, 2025
@kamarabbas99
Copy link
Contributor Author

/cc laoj2

@k8s-ci-robot k8s-ci-robot requested a review from laoj2 August 18, 2025 19:56
@kamarabbas99 kamarabbas99 changed the title Feature cpu ac Apply CPU startup boost in admission controller if its set Aug 18, 2025
@adrianmoisey
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 18, 2025
@adrianmoisey
Copy link
Member

This PR contains similar changes to #8417
I thought the plan was to split up into multiple changes?

Could we get #8417 merged first?

@kamarabbas99
Copy link
Contributor Author

@adrianmoisey yes I plan to rebase this once that PR is merged!

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 24, 2025
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 25, 2025
adrianmoisey
adrianmoisey reviewed Aug 27, 2025
View reviewed changes
vertical-pod-autoscaler/pkg/utils/annotations/vpa_cpu_boost.go
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to write some simple unit tests for these new functions?

adrianmoisey
adrianmoisey reviewed Aug 27, 2025
View reviewed changes
vertical-pod-autoscaler/pkg/admission-controller/resource/pod/patch/resource_updates.go
}

// NewResourceUpdatesCalculator returns a calculator for
// resource update patches.
func NewResourceUpdatesCalculator(recommendationProvider recommendation.Provider) Calculator {
func NewResourceUpdatesCalculator(recommendationProvider recommendation.Provider, maxAllowedCpu string) Calculator {
var maxAllowedCpuQuantity resource.Quantity
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
var maxAllowedCpuQuantity resource.Quantity
var maxAllowedCPUQuantity resource.Quantity

(just because the recommender uses maxAllowedCPU, with the upper-case CPU

adrianmoisey
adrianmoisey reviewed Aug 27, 2025
View reviewed changes
vertical-pod-autoscaler/pkg/admission-controller/resource/pod/patch/resource_updates.go
if features.Enabled(features.CPUStartupBoost) {
policy := vpa_api_util.GetContainerResourcePolicy(pod.Spec.Containers[i].Name, vpa.Spec.ResourcePolicy)
if policy != nil && policy.Mode != nil && *policy.Mode == vpa_types.ContainerScalingModeOff {
klog.V(4).Infof("Not applying startup boost for container %s since its scaling mode is Off", pod.Spec.Containers[i].Name)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you switch this to structured logging?

@adrianmoisey
Copy link
Member

I haven't gone over this in detail yet, just left some nits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwiesmueller kwiesmueller Awaiting requested review from kwiesmueller

@omerap12 omerap12 Awaiting requested review from omerap12

@laoj2 laoj2 Awaiting requested review from laoj2

1 more reviewer

@adrianmoisey adrianmoisey adrianmoisey left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kamarabbas99 @k8s-ci-robot @adrianmoisey