-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Utho autoscaler #8398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utho autoscaler #8398
Conversation
…, and restore toProviderID function
…ce node group tests
Welcome @manojdhanda! |
Hi @manojdhanda. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
…d license header to utils.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no comment on the utho specific files, but the integration code looks good to me. just a question about the dependency change for the maintainers.
cluster-autoscaler/go.mod
Outdated
github.com/pkg/errors v0.9.1 | ||
github.com/prometheus/client_golang v1.22.0 | ||
github.com/spf13/pflag v1.0.6 | ||
github.com/stretchr/testify v1.10.0 | ||
github.com/uthoplatforms/utho-go v0.2.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the past we've had concerns about adding more dependencies to the core, instead preferring to advise individual providers to add the dependencies in their directory. i'm not sure if we are still preferring that though, would want to get some input from other maintainers about this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do include providers in a common go module (w/ the exception of some provider-specific test modules), so we do have to manage a go.mod that is inclusive of core + providers.
That said, @elmiko is correct in that we want to prefer minimum impact to core modules as possible. Could we make changers to the provider implementation to reduce the impact to the main go.mod here @manojdhanda?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this is implemented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the updates @manojdhanda , i tested this out by building it with the utho
build tag and then also building the full autoscaler and testing the cluster-api provider. i did not test on an utho platform.
/lgtm
@elmiko @jackfrancis |
/ok-to-test |
Added |
/lgtm Welcome to the Cluster Autoscaler provider ecosystem, @manojdhanda @m-kased! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, manojdhanda The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds Utho as a new cloud provider to the Kubernetes Autoscaler. Utho is a cloud platform built in India, offering scalable compute infrastructure with APIs similar to AWS EC2. Integrating Utho into the Autoscaler allows users to dynamically scale their Kubernetes clusters on Utho, just like they do on GCP, AWS, or Azure.
Key highlights:
CloudProvider
,NodeGroup
, andInstance
interfaces specific to Utho.This feature will enable the Kubernetes community and Utho's customers to seamlessly auto-scale workloads based on resource utilization, contributing to performance, cost optimization, and high availability.
Special notes for your reviewer:
Does this PR introduce a user-facing change?