-
Notifications
You must be signed in to change notification settings - Fork 4.2k
cloudbuild.yaml file for cluster-autoscaler for automated builds #8066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cloudbuild.yaml file for cluster-autoscaler for automated builds #8066
Conversation
/hold I'm still running this locally to make sure but I believe this is roughly the right structure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
43d3027
to
c26d4ac
Compare
@jackfrancis mind taking another look? I think I've got it all working now. |
c26d4ac
to
c897c97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, raywainman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Modifies the cloudbuild.yaml file, containing the instructions to build cluster-autoscaler from Cloud Build in automated builds.
The old content here was a previous attempt at doing this but was abandoned, as far as I can tell it is all dead code.
Tested locally by running:
Which issue(s) this PR fixes:
Part of #8032.
Does this PR introduce a user-facing change?