Skip to content

Conversation

raywainman
Copy link
Member

@raywainman raywainman commented Apr 28, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Modifies the cloudbuild.yaml file, containing the instructions to build cluster-autoscaler from Cloud Build in automated builds.

The old content here was a previous attempt at doing this but was abandoned, as far as I can tell it is all dead code.

Tested locally by running:

$ gcloud builds submit --region=us-central1 --config=cloudbuild.yaml

Which issue(s) this PR fixes:

Part of #8032.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 28, 2025
@k8s-ci-robot k8s-ci-robot added area/cluster-autoscaler approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 28, 2025
@raywainman
Copy link
Member Author

/hold

I'm still running this locally to make sure but I believe this is roughly the right structure.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 28, 2025
Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Apr 28, 2025
@raywainman raywainman force-pushed the cluster-autoscaler-build branch from 43d3027 to c26d4ac Compare April 28, 2025 20:11
@raywainman
Copy link
Member Author

@jackfrancis mind taking another look? I think I've got it all working now.

@raywainman raywainman force-pushed the cluster-autoscaler-build branch from c26d4ac to c897c97 Compare April 28, 2025 21:28
Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, raywainman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@raywainman
Copy link
Member Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 28, 2025
@k8s-ci-robot k8s-ci-robot merged commit 130af54 into kubernetes:master Apr 28, 2025
7 checks passed
@raywainman raywainman deleted the cluster-autoscaler-build branch April 29, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants