Patch TestCleaningSoftTaintsInScaleDown to be compatible with new isScaleDownInCooldown signature

[mtrqq]

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

When both #7997 and #7995 were merged - this led to isScaleDownInCooldown interface incompatibility which causes tests to fail. This PR patches the test to no longer depend on isScaleDownInCooldown as tainting logic was transferred straight to RunOnce method

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

Hi @mtrqq. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mtrqq]

/assign abdelrahman882

[k8s-ci-robot]

@mtrqq: GitHub didn't allow me to assign the following users: abdelrahman882.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign abdelrahman882

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[abdelrahman882]

I see, #7997 removed the condition that cool down happens in case of no candidates, which was used by #7995 to put the cluster in cool down to test removing soft taints.

After #7997 now we have 3 branches to check

1. scaleDownInCooldown
2. len(scaleDownCandidates) == 0
3. otherwise

I think it's important to assert we remove soft taints in the three cases, so wdyt of

1. modifying the current tests with expectedScaleDownCoolDown=False for Emit scale down metric even when there is no scale down candidates. #7997
2. extending the test to use some other way to put cluster in cool down

cc: @damikag

[mtrqq]

I see, #7997 removed the condition that cool down happens in case of no candidates, which was used by #7995 to put the cluster in cool down to test removing soft taints.

After #7997 now we have 3 branches to check

1. scaleDownInCooldown
2. len(scaleDownCandidates) == 0
3. otherwise

I think it's important to assert we remove soft taints in the three cases, so wdyt of

1. modifying the current tests with expectedScaleDownCoolDown=False for Emit scale down metric even when there is no scale down candidates. #7997
2. extending the test to use some other way to put cluster in cool down

cc: @damikag

Makes perfect sense, added another clause to test for scale down in cooldown

[abdelrahman882]

Thanks Maksym

/lgtm

[k8s-ci-robot]

@abdelrahman882: changing LGTM is restricted to collaborators

In response to this:

Thanks Maksym

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[BigDarkClown]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BigDarkClown, mtrqq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cluster-autoscaler/OWNERS [BigDarkClown]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jackfrancis]

/cherry-pick cluster-autoscaler-release-1.32

[k8s-infra-cherrypick-robot]

@jackfrancis: new pull request created: #8111

In response to this:

/cherry-pick cluster-autoscaler-release-1.32

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.