Update to Kubernetes 1.30 #167
Merged
+922
−117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
Update all Kubernetes libraries to 1.30 and go to 1.22.
GO111MODULE=off is not supported in `go get` any longer. And running `go get github.com/alecthomas/gometalinter` would install the metalinter and its libs into go.mod / go.sum. Therefore remove the whole github.com/alecthomas/gometalinter installation, users must install it manually before running `make`. And we should move to another linter ASAP.
unittest.assertEquals has been removed from Python a long time ago. Use assert.Equal.
k8s-ci-robot
added
size/XL
|
I'm updating go version in kubernetes/test-infra#32493 |
|
CI failed. |
|
/retest |
|
Damn, I need to install gometalinter in CI somehow.
|
github.com/alecthomas/gometalinter has been deprecated for years and now it does not work with go 1.22. I'm removing it without replacement, our other sig-storage CSI projects do not use any linter either.
k8s-ci-robot
added
size/XXL
|
I removed the whole gometalinter, I did not make it work in go 1.22 easily and I don't think it's that useful either. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update all Kubernetes libraries to 1.30 and go to 1.22. Fix our code accordingly (
v1.ResourceRequirements->v1.VolumeResourceRequirements.When at it:
unittest.assertEqualshas been removed from Python (3.12).@xing-yang @msau42