Skip to content

📖 : add documentation about kubebuilder:scaffold marker #4173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2024
Merged

📖 : add documentation about kubebuilder:scaffold marker #4173

merged 1 commit into from
Sep 17, 2024

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Sep 15, 2024 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 15, 2024
@camilamacedo86 camilamacedo86 changed the title doc: add documenation about marker 📖 : add documentation about marker Sep 15, 2024
@camilamacedo86 camilamacedo86 changed the title 📖 : add documentation about marker 📖 : add documentation about kubebuilder:scaffold marker Sep 15, 2024
@camilamacedo86
Copy link
Member Author

c/c @AKarbas @carlisia, @ironreality, @jonnylangefeld, @YiannisGkoufas, @az0977776, @dlipovetsky, @LCaparelli, @invidian, @aharbis, @aliorouji

@camilamacedo86 camilamacedo86 mentioned this pull request Sep 15, 2024
Closed
maxsxu
maxsxu approved these changes Sep 17, 2024
View reviewed changes
Copy link

@maxsxu maxsxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Huge thanks for providing these information! Very helpful to understand kubebuilder better.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AKarbas, camilamacedo86, maxsxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@camilamacedo86 camilamacedo86 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2024
@k8s-ci-robot k8s-ci-robot merged commit 95dab95 into kubernetes-sigs:master Sep 17, 2024
10 checks passed
@camilamacedo86 camilamacedo86 deleted the add-doc-scaffold-marker branch September 17, 2024 14:36
@camilamacedo86 camilamacedo86 mentioned this pull request Oct 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kavinjsir Kavinjsir Awaiting requested review from Kavinjsir

@rashmigottipati rashmigottipati Awaiting requested review from rashmigottipati

2 more reviewers

@AKarbas AKarbas AKarbas approved these changes

@maxsxu maxsxu maxsxu approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation needed for +kubebuilder:scaffold markers
4 participants
@camilamacedo86 @k8s-ci-robot @AKarbas @maxsxu