Skip to content

Conversation

@snorwin
Copy link
Member

@snorwin snorwin commented Sep 24, 2025

What type of PR is this?

/kind test
/area conformance-test

What this PR does / why we need it:
Adds a normative conformance test for .spec.tls.backend.clientCertificateRef. The test verifies that the configured client certificate is presented when connecting to a backend over TLS.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 24, 2025
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added kind/test area/conformance-test Issues or PRs related to Conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 24, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 24, 2025
@snorwin
Copy link
Member Author

snorwin commented Sep 24, 2025

/cc @rikatz @kl52752

No rush on this, just whenever you have a moment. I was working on the feature in our implementation and thought it might be a good idea to propose a conformance test early.

@rikatz
Copy link
Member

rikatz commented Sep 26, 2025

/assign
Will take a look next week :D happy weekend!

@snorwin
Copy link
Member Author

snorwin commented Sep 29, 2025

/test all

@snorwin snorwin marked this pull request as ready for review November 8, 2025 08:59
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 8, 2025
@k8s-ci-robot k8s-ci-robot requested a review from candita November 8, 2025 08:59
Copy link
Contributor

@kl52752 kl52752 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for PR, LGTM!

@snorwin
Copy link
Member Author

snorwin commented Nov 18, 2025

/assign @robscott

@youngnick
Copy link
Contributor

This LGTM from what I can see, thanks @snorwin.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kl52752, snorwin, youngnick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2025
@snorwin
Copy link
Member Author

snorwin commented Nov 20, 2025

@arkodg is presenting a client certificate to the upstream based on .spec.tls.backend already implemented in Envoy Gateway? If so, I’d appreciate it if someone could review and verify this new conformance test.

I’ve already validated it using the Airlock Microgateway.

@arkodg
Copy link
Contributor

arkodg commented Nov 20, 2025

hey @snorwin this is not yet implemented in Envoy Gateway ( tracked with envoyproxy/gateway#4381)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance-test Issues or PRs related to Conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/test release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants