-
Notifications
You must be signed in to change notification settings - Fork 584
Implementing GEP-1767 CORS Filter for HTTPRoute #3637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4206666
to
067439a
Compare
067439a
to
6ccea3e
Compare
LGTM once tests pass. (I'll wait to give the command in case there are more code changes required) |
Looks good from here once tests pass, too. |
This has turned into quite the rabbit hole to get codegen working, CRDs properly sized, and presubmits passing. I may end up splitting some of these changes out into separate PRs if/when I get this working. /hold |
a993c82
to
e3b63a3
Compare
e3b63a3
to
6f57f25
Compare
I think this is in a good state now + tests are passing. I managed to avoid the scale of changes I'd originally expected here, so will not split this up. /hold cancel |
Quite the road getting this last bit in! /lgtm |
Can I ask when this is likely going to be released? I am working on an implementation of Gateway API currently with Istio and require CORS support in HTTPRoute |
This will be included in Gateway API v1.3, due out March 24th. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This is an implementation of GEP #1767 as written by @lianglli. @mkosieradzki started the work on this PR and I finished it off with some codegen and validation.
Does this PR introduce a user-facing change?: