Skip to content

Conversation

robscott
Copy link
Member

What type of PR is this?
/kind feature

What this PR does / why we need it:
This is an implementation of GEP #1767 as written by @lianglli. @mkosieradzki started the work on this PR and I finished it off with some codegen and validation.

Does this PR introduce a user-facing change?:

A new CORS filter has been added to HTTPRoute

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 27, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2025
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 27, 2025
@youngnick
Copy link
Contributor

LGTM once tests pass. (I'll wait to give the command in case there are more code changes required)

@kflynn
Copy link
Contributor

kflynn commented Feb 27, 2025

Looks good from here once tests pass, too.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 27, 2025
@robscott
Copy link
Member Author

This has turned into quite the rabbit hole to get codegen working, CRDs properly sized, and presubmits passing. I may end up splitting some of these changes out into separate PRs if/when I get this working.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2025
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 27, 2025
@robscott
Copy link
Member Author

I think this is in a good state now + tests are passing. I managed to avoid the scale of changes I'd originally expected here, so will not split this up.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 28, 2025
@kflynn
Copy link
Contributor

kflynn commented Feb 28, 2025

Quite the road getting this last bit in!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2025
@k8s-ci-robot k8s-ci-robot merged commit a5be7b5 into kubernetes-sigs:main Feb 28, 2025
13 checks passed
@AdamS3x
Copy link

AdamS3x commented Mar 4, 2025

Can I ask when this is likely going to be released? I am working on an implementation of Gateway API currently with Istio and require CORS support in HTTPRoute

@youngnick
Copy link
Contributor

This will be included in Gateway API v1.3, due out March 24th.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants