-
Notifications
You must be signed in to change notification settings - Fork 585
Spelling (and make links accessible) #3615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
4284ba2
37a8d38
e2b7008
3d312c6
4d04452
b7fe69c
a788a52
704b864
1ca2c67
aed4530
3520c36
586335d
e7593d6
7530668
6d96bd4
9e36b96
54dc4bf
494f338
230f8db
15f6549
e1ebbda
f1b1d61
e39da4f
48b9d5d
813568c
23400b6
8f0d1c2
da5a13e
1c70bbb
18034d0
e4a0803
68c2472
54eaaba
b0b1fc1
c397565
28015e6
a1e7d34
c4112eb
8ab9a79
9dd57dd
1874d08
d904f5d
eaae7f8
08a3192
ecf9a72
ee421f9
c2ff05e
1ec12e5
a902b0f
e4983fb
06f7a21
2a435da
6ea5af2
3f8b37f
bfa29ec
bc41f28
d8500df
372d75d
4c2f5ab
26a1ef9
efee416
bac79c7
9d58049
01dcba7
16f8771
e38ef0c
6aaf8cd
c52774a
bb15f16
d13e722
176c2a1
4f4df69
1e85bad
31f72bd
5937f6a
f8e1b03
790875e
5935919
0019750
1946ce0
d6ccadc
78c5df0
c09dfac
ff2af48
cbea5db
b4d82ed
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,6 @@ | |
|
||
|API channel|Implementation version|Mode|Report| | ||
|-----------|----------------------|----|------| | ||
|x|[v1.14.0](https://github.com/cilium/cilium/releases/tag/v1.14.0)|x|[link](./v1.14.0-report.yaml)| | ||
|x|[v1.14.0](https://github.com/cilium/cilium/releases/tag/v1.14.0)|x|[v1.14.0 report](./v1.14.0-report.yaml)| | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In all of these cases, these are submitted via PR, so we'll need to be diligent in checking new versions contain text other than There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, do see #3615 (comment) |
||
|
||
## Reproduce |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,6 @@ | |
|
||
|API channel|Implementation version|Mode|Report| | ||
|-----------|----------------------|----|------| | ||
|x|[v0.5.0](https://github.com/nginx/nginx-gateway-fabric/releases/tag/v0.5.0)|x|[link](./v1.1.0-report.yaml)| | ||
|x|[v0.5.0](https://github.com/nginx/nginx-gateway-fabric/releases/tag/v0.5.0)|x|[v0.5.0 report](./v0.5.0-report.yaml)| | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is notable, the link was bad... |
||
|
||
## Reproduce |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,6 @@ | |
|
||
|API channel|Implementation version|Mode|Report| | ||
|-----------|----------------------|----|------| | ||
|x|[2.4.1](https://github.com/kumahq/kuma/releases/tag/2.4.1)|x|[link](./2.4.1-report.yaml)| | ||
|x|[2.4.1](https://github.com/kumahq/kuma/releases/tag/2.4.1)|x|[v2.4.1 report](./2.4.1-report.yaml)| | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fwiw, I'd be inclined to change the |
||
|
||
## Reproduce |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,11 +4,11 @@ | |
|
||
|API channel|Implementation version|Mode|Report| | ||
|-----------|----------------------|----|------| | ||
|experimental|[v1.27.0](https://github.com/projectcontour/contour/releases/tag/v1.27.0)|x|[link](./v1.27.0-report.yaml)| | ||
|experimental|[v1.27.1](https://github.com/projectcontour/contour/releases/tag/v1.27.1)|x|[link](./v1.27.1-report.yaml)| | ||
|experimental|[v1.27.2](https://github.com/projectcontour/contour/releases/tag/v1.27.2)|x|[link](./v1.27.2-report.yaml)| | ||
|experimental|[v1.27.3](https://github.com/projectcontour/contour/releases/tag/v1.27.3)|x|[link](./v1.27.3-report.yaml)| | ||
|experimental|[v1.27.4](https://github.com/projectcontour/contour/releases/tag/v1.27.4)|x|[link](./experimental-v1.27.4-default-report.yaml)| | ||
|experimental|[v1.27.0](https://github.com/projectcontour/contour/releases/tag/v1.27.0)|x|[v1.27.0 report](./v1.27.0-report.yaml)| | ||
|experimental|[v1.27.1](https://github.com/projectcontour/contour/releases/tag/v1.27.1)|x|[v1.27.1 report](./v1.27.1-report.yaml)| | ||
|experimental|[v1.27.2](https://github.com/projectcontour/contour/releases/tag/v1.27.2)|x|[v1.27.2 report](./v1.27.2-report.yaml)| | ||
|experimental|[v1.27.3](https://github.com/projectcontour/contour/releases/tag/v1.27.3)|x|[v1.27.3 report](./v1.27.3-report.yaml)| | ||
|experimental|[v1.27.4](https://github.com/projectcontour/contour/releases/tag/v1.27.4)|x|[v1.27.4 report](./experimental-v1.27.4-default-report.yaml)| | ||
Comment on lines
+10
to
+11
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm aware that the file names sometimes hint at |
||
|
||
## Reproduce | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,9 +4,9 @@ | |
|
||
|API channel|Implementation version|Mode|Report| | ||
|-----------|----------------------|----|------| | ||
|standard|1.30.3-gke.1211000|gke-l7-global-external-managed|[link](./standard-1.30.3-gxlb-report.yaml)| | ||
|standard|1.30.3-gke.1211000|gke-l7-regional-external-managed|[link](./standard-1.30.3-rxlb-report.yaml)| | ||
|standard|1.30.3-gke.1211000|gke-l7-rilb|[link](./standard-1.30.3-rilb-report.yaml)| | ||
|standard|1.30.3-gke.1211000|gke-l7-global-external-managed|[v1.30.3 gxlb report](./standard-1.30.3-gxlb-report.yaml)| | ||
|standard|1.30.3-gke.1211000|gke-l7-regional-external-managed|[v1.30.3 rxlb report](./standard-1.30.3-rxlb-report.yaml)| | ||
|standard|1.30.3-gke.1211000|gke-l7-rilb|[v1.30.3 rilb report](./standard-1.30.3-rilb-report.yaml)| | ||
Comment on lines
+7
to
+9
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've generally avoided adding any additional words beyond |
||
|
||
## Reproduce | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes the instructions which should help with future pull requests, but, indeed a linter is necessary.
I'm, of course, using one, and if people like the results, I'm happy to talk with them about it, but it's outside the scope of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, this is great, thanks.