ListenerSet APIs + Generated Clients #3588

dprotaso · 2025-02-03T22:15:53Z

Part of #1713

Merge #3589 beforehand (to make this diff easier)

Note: this required two different client sets because if you try to generate a client set containing the stable group (gateway.networking.k8s.io) and experimental (gateway.networking.k8s-x.io) client-gen uses gateway part from both api groups for naming in the client set and it creates a conflict

refactor codegen scripts to make it easier to generate two clients (to be removed)
add listenerset types
adjust GEP to match go type
run deepcopy-gen & register-gen
perform code generation

Release Note

Introduces ListenerSet API & Generate Clients (in the group gateway.networking.k8s-x.io)

dprotaso · 2025-02-03T22:16:26Z

I'm going to pull

refactor codegen scripts to make it easier to generate two clients

Into a separate PR

dprotaso · 2025-02-03T22:17:53Z

/hold for #3589

apisx/v1alpha1/listenerset_types.go

dprotaso · 2025-02-04T00:21:06Z

/hold need to add the Gateway changes

dprotaso · 2025-02-04T00:47:08Z

/hold cancel

dprotaso · 2025-02-06T15:55:10Z

Note: this required two different client sets because if you try to generate a client set containing the stable group (gateway.networking.k8s.io) and experimental (gateway.networking.k8s-x.io) client-gen uses gateway part from both api groups for naming in the client set and it creates a conflict

Ok - I figured out there's a marker

+groupGoName=SomeUniqueShortName

So we could have a single clientset that has stable and experimental apis - let me know what people prefer

geps/gep-1713/index.md

apis/v1/gateway_types.go

shaneutt

I think overall we're heading in a good direction here, but I think we need to reiterate what feels like a more obvious question as I read more: "What is a Gateway after this, really?"

Personally I'll have to think on this quite a bit and come back around to it 🤔

dprotaso · 2025-02-25T16:37:05Z

Namespace support is in a follow up PR #3632

shaneutt

We still need to update the GEP status to Experimental.

apis/v1/gateway_types.go

shaneutt

Thank you @dprotaso for working this one for many months, through issues, discussions, zoom syncs, and PRs. Also thank you for #3632 I think it'll be fantastic if we can get that into 1.3 as well.

Once everyone's current comments are resolved, I think this is ready to move into experimental and start getting feedback from implementations.

/approve

robscott

Thanks @dprotaso! One nit, otherwise LGTM.

apis/v1/gateway_types.go

apisx/v1alpha1/shared_types.go

youngnick · 2025-02-26T06:26:04Z

LGTM with @robscott's requested changes.

mlavacca

Once the remaining comments are resolved, lgtm!

k8s-ci-robot · 2025-02-26T08:22:53Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, mlavacca, robscott, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [mlavacca,robscott,shaneutt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dprotaso · 2025-02-26T18:37:21Z

All comments are resolved - PTAL and once this is merged I'll rebase the other PR.

robscott · 2025-02-26T18:40:59Z

Thanks @dprotaso!

/lgtm
/hold cancel

* add listenerset types * adjust GEP to match go type * run deepcopy-gen & register-gen * perform code generation * Add ListenerSetList type * remove TODO for cel validation that allows an optional port * add Gateway allowedListeners property * Add 'None' as an allowable option for FromNamespaces * combine into a single client * fix group name to be x-k8s.io * add a blurb about listener conflict * listener names don't need to be unique across listenersets and gateways * change use of ListenerSet conditions to a MUST requirement * add a Programmed Reason of ParentNotProgrammed * fix typo * parentRef is not optional * add a note about Gateway Listener list MAY drop MinItems=1 requirement * Update GEP to experimental * update GEP metadata * AllowedListeners is no longer a list

* apis: add implementation for GEP-3388 HTTPRoute Retry Budget * fmt and add descriptions for parameters * Move GEP 3388 to Experimental * make generate * Minor change * Require both parameters of RequestRate * Begin fixing Retry description. Add defaults, some validation, in CommonRetryPolicy * Taking the liberty of renaming CommonRetryPolicy to RetryConstraint * Shamelessly copying from backendlbpolicy and backendtlspolicy to conform with api structure * Fleshing out the description for RetryConstraint * refactor codegen scripts to make it easier to generate two clients * Attempting to match the experimental API structure that dprotaso made in #3588 * Delete files that were generated before moving to apisx * undo commenting * Working to fix code gen following merge * Fix api group name * capitalize RFC 2119 keyword * Addressing comments from code review * missing file * fix imports * Modify descriptions; add greater validation * Update apisx/v1alpha2/backendtrafficpolicy.go Co-authored-by: Rob Scott <[email protected]> * Not complete, but adding CEL tests for backend traffic policy * fix missing retryConstraint in test struct; add tests for invalid config * move to apis/v1alpha1 * add main_test * rename file * fix missing quotes :) * fix CEL condition * move validation message to interval field directly * remove unused apisx/v1alpha2 file * remove more files from before merging experimental api versions --------- Co-authored-by: Dave Protasowski <[email protected]> Co-authored-by: Rob Scott <[email protected]>

GEP-1713 was previously listed as provisional, but PR kubernetes-sigs#3588 moved it to experimental.

GEP-1713 was previously listed as provisional in the website, but PR kubernetes-sigs#3588 moved it to experimental.

GEP-1713 was previously listed as provisional in the website, but PR #3588 moved it to experimental.

GEP-1713 was previously listed as provisional in the website, but PR kubernetes-sigs#3588 moved it to experimental.

zirain · 2025-04-04T01:42:04Z

apis/v1/gateway_types.go

 	// Gateway.
 	NamespacesFromSame FromNamespaces = "Same"
+	// No Routes/ListenerSets may be attached to this Gateway.
+	NamespacesFromNone FromNamespaces = "None"


@dprotaso what's the user case for None?

k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Feb 3, 2025

k8s-ci-robot requested review from kflynn and mlavacca February 3, 2025 22:16

dprotaso mentioned this pull request Feb 3, 2025

refactor codegen scripts to make it easier to generate two clients #3589

Merged

dprotaso force-pushed the listenerset branch from d1c440a to 389a354 Compare February 3, 2025 22:46

dprotaso changed the title ~~ListenerSet APIs + Generated Clients~~ [wip] ListenerSet APIs + Generated Clients Feb 3, 2025

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 3, 2025

dprotaso changed the title ~~[wip] ListenerSet APIs + Generated Clients~~ ListenerSet APIs + Generated Clients Feb 3, 2025

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 3, 2025

dprotaso commented Feb 3, 2025

View reviewed changes

apisx/v1alpha1/listenerset_types.go Outdated Show resolved Hide resolved

k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 4, 2025

shaneutt self-assigned this Feb 6, 2025

shaneutt self-requested a review February 6, 2025 15:52

shaneutt requested review from robscott and youngnick February 6, 2025 15:57

shaneutt requested changes Feb 7, 2025

View reviewed changes

geps/gep-1713/index.md Show resolved Hide resolved

shaneutt reviewed Feb 7, 2025

View reviewed changes

apis/v1/gateway_types.go Show resolved Hide resolved

shaneutt reviewed Feb 7, 2025

View reviewed changes

shaneutt requested changes Feb 25, 2025

View reviewed changes

apis/v1/gateway_types.go Show resolved Hide resolved

Update GEP to experimental

a422dea

shaneutt approved these changes Feb 25, 2025

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2025

robscott approved these changes Feb 26, 2025

View reviewed changes

apis/v1/gateway_types.go Outdated Show resolved Hide resolved

apisx/v1alpha1/shared_types.go Show resolved Hide resolved

robscott added this to the v1.3.0 milestone Feb 26, 2025

mlavacca approved these changes Feb 26, 2025

View reviewed changes

dprotaso added 2 commits February 26, 2025 13:25

update GEP metadata

24ec4d7

AllowedListeners is no longer a list

c90bd20

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 26, 2025

k8s-ci-robot assigned robscott Feb 26, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2025

k8s-ci-robot merged commit 79af272 into kubernetes-sigs:main Feb 26, 2025
13 checks passed

dprotaso deleted the listenerset branch February 26, 2025 19:30

gcs278 added a commit to gcs278/gateway-api that referenced this pull request Mar 7, 2025

GEP-1713: Move Website GEP Link to Experimental

79557d7

GEP-1713 was previously listed as provisional, but PR kubernetes-sigs#3588 moved it to experimental.

gcs278 added a commit to gcs278/gateway-api that referenced this pull request Mar 7, 2025

GEP-1713: Move Website GEP Link to Experimental

b2cd3bc

GEP-1713 was previously listed as provisional in the website, but PR kubernetes-sigs#3588 moved it to experimental.

gcs278 mentioned this pull request Mar 7, 2025

GEP-1713: Move Website GEP Link to Experimental #3664

Merged

k8s-ci-robot pushed a commit that referenced this pull request Mar 10, 2025

GEP-1713: Move Website GEP Link to Experimental (#3664)

84e36f2

GEP-1713 was previously listed as provisional in the website, but PR #3588 moved it to experimental.

EyalPazz pushed a commit to EyalPazz/gateway-api that referenced this pull request Mar 18, 2025

GEP-1713: Move Website GEP Link to Experimental (kubernetes-sigs#3664)

57b8fe2

GEP-1713 was previously listed as provisional in the website, but PR kubernetes-sigs#3588 moved it to experimental.

zirain reviewed Apr 4, 2025

View reviewed changes

zirain mentioned this pull request Apr 4, 2025

gateway api: Support None allowed route mode istio/istio#55781

Closed

howardjohn mentioned this pull request Apr 11, 2025

Remove newly introduced NamespacesFromNone #3743

Closed

ListenerSet APIs + Generated Clients #3588

ListenerSet APIs + Generated Clients #3588

Uh oh!

Conversation

dprotaso commented Feb 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Release Note

Uh oh!

dprotaso commented Feb 3, 2025

Uh oh!

dprotaso commented Feb 3, 2025

Uh oh!

Uh oh!

dprotaso commented Feb 4, 2025

Uh oh!

dprotaso commented Feb 4, 2025

Uh oh!

dprotaso commented Feb 6, 2025

Uh oh!

Uh oh!

Uh oh!

shaneutt left a comment

Choose a reason for hiding this comment

Uh oh!

dprotaso commented Feb 25, 2025

Uh oh!

shaneutt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shaneutt left a comment

Choose a reason for hiding this comment

Uh oh!

robscott left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

youngnick commented Feb 26, 2025

Uh oh!

mlavacca left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Feb 26, 2025

Uh oh!

dprotaso commented Feb 26, 2025

Uh oh!

robscott commented Feb 26, 2025

Uh oh!

Uh oh!

zirain Apr 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dprotaso commented Feb 3, 2025 •

edited

Loading