-
Notifications
You must be signed in to change notification settings - Fork 585
Grouping GEPs by status, cleaning up GEP related docs #1440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In favor. One comment about scratch docs which I hope I can persuade others about, but I don't consider it a blocker for merging this.
39dfc42
to
4b54cb6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with very minor revisions, holding the final merge just to ensure other maintainers can weigh in too.
This LGTM once @mikemorris' comments are sorted. |
4b54cb6
to
aff5842
Compare
Thanks for the reviews! Responded to everything, PTAL. |
/lgtm Not sure if I'll need to do that again once you rebase. |
This also replaces the "Implemented" status with new "Experimental" and "Standard" states that make it clearer how far a GEP has made it. Some GEPs had not properly updated their status, this ensures that all GEPs have an accurate status.
aff5842
to
d5bdaf5
Compare
Thanks for the reviews @shaneutt @mikemorris and @youngnick! Mind taking one more look after latest rebase? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikemorris, robscott, shaneutt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This commit fixes a few links that were incorrectly being rendered as markdown instead of HTML anchors, or were pointing to outdated URL paths. * Fix broken anchor link in GEP-713. Missed in kubernetes-sigs#2448 when section header was updated. * Fix broken link to GEP States in GEP-91. Page was moved to a new location in kubernetes-sigs#1440 and section heading was renamed in kubernetes-sigs#2689. * Fix broken link to GRPCRouteRule.Name in docs for GRPCRoute API type. Missed in kubernetes-sigs#3299. Signed-off-by: Blake Covarrubias <[email protected]>
This commit fixes a few links that were incorrectly being rendered as markdown instead of HTML anchors, or were pointing to invalid URLs. * Fixed a broken anchor link in GEP-713. Missed in kubernetes-sigs#2448 when section header was updated. * Fixed a broken link to GEP States in GEP-91. Page was moved to a new location in kubernetes-sigs#1440 and section heading was renamed in kubernetes-sigs#2689. * Fixed link to policy attachment docs in GEP-1323. * Fixed link to ListenerSets GitHub issue in GEP-1713. * Fixed link to Envoy's RequestMirrorPolicy route action in GEP-3171. Signed-off-by: Blake Covarrubias <[email protected]>
This commit fixes a few links that were incorrectly being rendered as markdown instead of HTML anchors, or were pointing to invalid URLs. * Fixed a broken link to GEP States in GEP-91. Page was moved to a new location in kubernetes-sigs#1440 and section heading was renamed in kubernetes-sigs#2689. * Fixed a broken anchor link in GEP-713. Missed in kubernetes-sigs#2448 when section header was updated. * Fixed link to policy attachment docs in GEP-1323. * Fixed link to ListenerSets GitHub issue in GEP-1713. * Fixed link to Envoy's RequestMirrorPolicy route action in GEP-3171. * Fixed link to Flomesh Gateway API on implementations page. Signed-off-by: Blake Covarrubias <[email protected]>
This commit fixes a few links that were incorrectly being rendered as markdown instead of HTML anchors, or were pointing to invalid URLs. * Fixed a broken link to GEP States in GEP-91. Page was moved to a new location in #1440 and section heading was renamed in #2689. * Fixed a broken anchor link in GEP-713. Missed in #2448 when section header was updated. * Fixed link to policy attachment docs in GEP-1323. * Fixed link to ListenerSets GitHub issue in GEP-1713. * Fixed link to Envoy's RequestMirrorPolicy route action in GEP-3171. * Fixed link to Flomesh Gateway API on implementations page. Signed-off-by: Blake Covarrubias <[email protected]>
What type of PR is this?
/kind documentation
What this PR does / why we need it:
This PR includes a lot of GEP related cleanup, including:
contributing/geps
togeps/overview
Does this PR introduce a user-facing change?: