admissionv1.AddToScheme needs to be called for v1.AdmissionReview

[ellistarn]

Controller-gen 0.4.0 now uses v1 types. This needs to be included here: https://github.com/kubernetes-sigs/controller-runtime/blob/master/pkg/webhook/admission/http.go#L28

2020-09-14T19:47:34.638Z	DEBUG	controller-runtime.webhook.webhooks	wrote response	{"webhook": "/mutate", "UID": "", "allowed": false, "result": {}, "resultError": "got runtime.Object without object metadata: &Status{ListMeta:ListMeta{SelfLink:,ResourceVersion:,Continue:,RemainingItemCount:nil,},Status:,Message:no kind \"AdmissionReview\" is registered for version \"admission.k8s.io/v1\" in scheme \"pkg/runtime/scheme.go:101\",Reason:,Details:nil,Code:400,}"}

[ellistarn]

@DirectXMan12 any word here?

[vincepri]

Do we want to support only admission request v1, or both?

[ellistarn]

For backwards compatibility, I think both need to be supported.

[ellistarn]

For any kubebuilder users, I'm temporarily fixing this with

perl -pi -e 's/^  - v1$$//g' config/webhook/manifests.yaml

[bsctl]

Hello team, any plan on this?

[camilamacedo86]

HI @ellistarn and @bsctl,

Shows that it is done in the master with #1293. COuld you please check and close this one if it is the case?

[ellistarn]

Will check it out! Thanks.

[prometherion]

Hey @camilamacedo86, thanks for sharing these: everything works fine with the latest versions, thanks a lot! 🙌🏻