Skip to content

Conversation

BlaineEXE
Copy link
Contributor

@BlaineEXE BlaineEXE commented Jan 24, 2025

Fix an out of sync reference to the old API repository in Dockerfiles.

The controller and sidecar dockerfiles, generated from this Dockerfile.in, are already correct, but .in template doesn't have the change. This was likely a recent minor oversight. Once we implement the prow job to check generated files, this should be prevented in the future.

Fix an out of sync reference to the old API repository in Dockerfiles.

Signed-off-by: Blaine Gardner <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 24, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BlaineEXE

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 24, 2025
@shanduur
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2025
@k8s-ci-robot k8s-ci-robot merged commit 0cc7472 into kubernetes-sigs:main Jan 25, 2025
3 of 4 checks passed
@BlaineEXE BlaineEXE deleted the resync-Dockerfiles branch January 27, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants