✨ Optimize size of runtime hook requests #12462
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/L
sbueringer
added
area/runtime-sdk
|
/assign @fabriziopandini |
|
/test pull-cluster-api-e2e-main |
sbueringer
force-pushed
the
pr-optimize-runtime-calls
branch
from
45cddad to
e1e59cb
Compare
|
/test pull-cluster-api-e2e-main |
| @@ -1185,6 +1187,22 @@ func TestComputeControlPlaneVersion(t *testing.T) { | |||
| ObjectMeta: metav1.ObjectMeta{ | |||
| Name: "test-cluster", | |||
| Namespace: "test-ns", | |||
| // Add managedFields and annotations that should be cleaned up before the Cluster is sent to the RuntimeExtension. | |||
There was a problem hiding this comment.
Are we confident that a runtime extension wouldn't be relying on the managed fields at all?
There was a problem hiding this comment.
I think it shouldn't depend on the information when which field was written by whom.
As this is all still alpha, I think it's a good time to drop this info.
There was a problem hiding this comment.
I can't actually know that nobody is using this, but in my opinion it's very very unlikely.
There was a problem hiding this comment.
Ack, happy to take the risk and see who complains, one of those things of, if it's there, someone is probably using it, but lets see
There was a problem hiding this comment.
ManagedFields are really hard to consume :)
sbueringer
added
the
tide/merge-method-squash
|
/test pull-cluster-api-e2e-main |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 1762205563bea29118ce5be2f947ab626508a0d2
|
|
/override pull-cluster-api-e2e-main |
|
@sbueringer: Overrode contexts on behalf of sbueringer: pull-cluster-api-e2e-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What this PR does / why we need it:
Currently we're sending too much information in our runtime hook requests.
This PR optimizes the runtime hook request sizes by dropping:
Kudos to @fabriziopandini for the idea!
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #