⚠️ Make Template in MachineSet & Spec in MachineTemplateSpec required #12420
+13
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
do-not-merge/needs-area
|
/test pull-cluster-api-e2e-main |
|
/assign @JoelSpeed @fabriziopandini @sivchari |
JoelSpeed
reviewed
Jun 30, 2025
| // +optional | ||
| Template MachineTemplateSpec `json:"template,omitempty"` | ||
| // +required | ||
| Template MachineTemplateSpec `json:"template"` |
There was a problem hiding this comment.
The two fields in the MachineTemplateSpec are both currently optional, seems this won't achieve much without making the spec inside the template required?
There was a problem hiding this comment.
Good point, thx. I'll look into it
sbueringer
force-pushed
the
pr-template-required
branch
from
c99ba51 to
88625bc
Compare
sbueringer
changed the title
Signed-off-by: Stefan Büringer [email protected]
sbueringer
force-pushed
the
pr-template-required
branch
from
88625bc to
19f51c9
Compare
|
@JoelSpeed PTAL :) |
k8s-ci-robot
added
size/S
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 85fe0e3a0b9e5ac24838bf61d8727118c1c0b62c
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
62 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Just doesn't make sense for this to be optional
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #10852