⚠️ Remove DefaulterRemoveUnknownOrOmitableFields mutating webhook option (again) #12404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/clusterclass
|
/test pull-cluster-api-e2e-conformance-ci-latest-main |
fabriziopandini
force-pushed
the
drop-DefaulterRemoveUnknownOrOmitableFields
branch
from
010219e to
f109de6
Compare
62 tasks
sbueringer
reviewed
Jun 26, 2025
sbueringer
reviewed
Jun 26, 2025
sivchari
reviewed
Jun 27, 2025
fabriziopandini
added
the
tide/merge-method-squash
|
/approve /assign @sivchari |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Thx! /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: c4497535825c2c8fc13db346371bb6c7f460ba9e
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
#12231 dropped DefaulterRemoveUnknownOrOmitableFields from all mutating web hook.
Before the alpha release, #12290 partially reverted this change because we were observing issue in KCP.
Now, after triaging the issue in KCP, and opened #12402 to fix it, we can finally drop DefaulterRemoveUnknownOrOmitableFields mutating webhook option (again).
Additionally, this PR adds a unit test that proves that dropping DefaulterRemoveUnknownOrOmitableFields do not lead to rollouts or infinite reconciles in the topology controller.
However, in case you have patches generating omitable fields like e.g. an empty string, or an empty array, this might lead to rollouts when you rebase to a cluster class using v1beta2 references (or you change a cluster class in place, which is not recommended).
/area clusterclass
Part of #10852