⚠️ Promote v1beta2 condition in CAPD #12362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sivchari <[email protected]>
Signed-off-by: sivchari <[email protected]>
Signed-off-by: sivchari <[email protected]>
Signed-off-by: sivchari <[email protected]>
Signed-off-by: sivchari <[email protected]>
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/XXL
sivchari
commented
Jun 15, 2025
Signed-off-by: sivchari <[email protected]>
Signed-off-by: sivchari <[email protected]>
Signed-off-by: sivchari <[email protected]>
sivchari
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/cc @sbueringer @fabriziopandini Ready for review 👍 |
sbueringer
added
the
area/provider/infrastructure-docker
|
/assign @fabriziopandini |
There was a problem hiding this comment.
Thanks @sivchari for this work, just a few nits from my side
test/infrastructure/docker/exp/api/v1beta2/dockermachinepool_types.go
Outdated
Show resolved
Hide resolved
fabriziopandini
changed the title
Signed-off-by: sivchari <[email protected]>
|
@fabriziopandini |
Signed-off-by: sivchari <[email protected]>
|
/test pull-cluster-api-e2e-main |
sbueringer
reviewed
Jun 20, 2025
test/infrastructure/docker/internal/controllers/dockermachine_controller.go
Outdated
Show resolved
Hide resolved
|
@sivchari Thank you very much!! Just a few minor findings |
Signed-off-by: sivchari <[email protected]>
sivchari
force-pushed
the
promote-v1beta2-condition
branch
from
b40f68b to
b671e8f
Compare
|
I fixed some review findings and left comments. |
|
If you can fix #12362 (comment) then we can merge and keep moving |
Signed-off-by: sivchari <[email protected]>
|
Thanks! @fabriziopandini |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: e57c612d2fbb62ed958fa36ab4af7589ba7db6db
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
fabriziopandini
added
the
tide/merge-method-squash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Part of #11947
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #