-
Notifications
You must be signed in to change notification settings - Fork 1.4k
✨ From 1.10 use GetStableReleaseOfMinor instead of GetLatestReleaseOfMinor #12118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ From 1.10 use GetStableReleaseOfMinor instead of GetLatestReleaseOfMinor #12118
Conversation
- From 1.10 use GetStableReleaseOfMinor instead of GetLatestReleaseOfMinor Signed-off-by: cprivitere <[email protected]>
/test |
@fabriziopandini: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test pull-cluster-api-e2e-main |
/lgtm /cherry-pick release-1.10 |
@fabriziopandini: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
LGTM label has been added. Git tree hash: e4d0c561d9e279280f9c5064e475c505a26a5a14
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@fabriziopandini: #12118 failed to apply on top of branch "release-1.10":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
NOTE: cherry pick is not required, GetLatestReleaseOfMinor was used for v1.10=>current tests, and those tests exists only on main |
What this PR does / why we need it: Per the 1.10 Release Tasks, we need to:
"Fix clusterctl upgrade tests starting from 1.10 to use GetStableReleaseOfMinor instead of GetLatestReleaseOfMinor"
I believe the correct procedure is to commit this to main and then cherry pick to 1.10, but let me know if that's not the case and I'll resubmit corrected PRs.
/area e2e-testing