Skip to content

Conversation

@nikParasyr
Copy link
Contributor

What this PR does / why we need it:
Define subnetID on ovn LB member creation when the user is using different networks for the cluster and the loadbalancer

Which issue(s) this PR fixes:
Fixes #2790

Special notes for your reviewer:
In general I have some concerns with the approach, would like input from your side:

  1. I'm using openStackCluster.Status.APIServerLoadBalancer.LoadBalancerNetwork.ID. While working on this i noticed that the field is not always populated ( related PR )
  2. I'm checking whether the provider is "ovn", amphora also supports different subnet IDs (although i've never seen it in action). I could drop this check but it would require point 1 being resolved ( in theory we could always set subnetID on member create opts == openStackCluster.Status.Network.Subnets[0].ID -- see point 3 )
  3. The subnetID is set to openStackCluster.Status.Network.Subnets[0].ID. A control-plane machine can be attached to different subnets ( if OSM.spec.ports. are defined ). I couldnt find a way to get the subnetID from the spec though as a user can define just a spec.ports[0].network.id (or a filter) and OSM.status doesn't provide info on subnetID. So the assumption is that the control-plane machine is using the cluster subnet.

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 25, 2025
@netlify
Copy link

netlify bot commented Oct 25, 2025

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit ccba74b
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-openstack/deploys/69032cc58f9cc400087006e1
😎 Deploy Preview https://deploy-preview-2799--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign neolit123 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 25, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @nikParasyr. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nikParasyr nikParasyr changed the title Define subnetID when creating ovn LB member 🐛 Define subnetID when creating ovn LB member Oct 25, 2025
@lentzi90
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 29, 2025
Define subnetID on ovn LB member creation when the
user is using different networks for the cluster
and the loadbalancer
@nikParasyr
Copy link
Contributor Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

Status: Inbox

Development

Successfully merging this pull request may close these issues.

Loadbalancer member not created with subnet id

3 participants