- 
                Notifications
    You must be signed in to change notification settings 
- Fork 281
🐛 Define subnetID when creating ovn LB member #2799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| ✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
 To edit notification comments on pull requests, go to your Netlify project configuration. | 
| [APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. 
Needs approval from an approver in each of these files:
 Approvers can indicate their approval by writing  | 
| Hi @nikParasyr. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with  Once the patch is verified, the new status will be reflected by the  I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. | 
283dca2    to
    0bf4234      
    Compare
  
    | /ok-to-test | 
Define subnetID on ovn LB member creation when the user is using different networks for the cluster and the loadbalancer
0bf4234    to
    ccba74b      
    Compare
  
    | /retest | 
What this PR does / why we need it:
Define subnetID on ovn LB member creation when the user is using different networks for the cluster and the loadbalancer
Which issue(s) this PR fixes:
Fixes #2790
Special notes for your reviewer:
In general I have some concerns with the approach, would like input from your side:
openStackCluster.Status.APIServerLoadBalancer.LoadBalancerNetwork.ID. While working on this i noticed that the field is not always populated ( related PR )openStackCluster.Status.Network.Subnets[0].ID-- see point 3 )openStackCluster.Status.Network.Subnets[0].ID. A control-plane machine can be attached to different subnets ( ifOSM.spec.ports. are defined ). I couldnt find a way to get the subnetID from the spec though as a user can define just aspec.ports[0].network.id(or a filter) andOSM.statusdoesn't provide info on subnetID. So the assumption is that the control-plane machine is using the cluster subnet.TODOs:
/hold