- 
                Notifications
    You must be signed in to change notification settings 
- Fork 281
🌱Add image validation for openstack machine #2665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| ✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
 To edit notification comments on pull requests, go to your Netlify project configuration. | 
| 
 
 | 
| Welcome @smoshiur1237!  | 
| Hi @smoshiur1237. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with  Once the patch is verified, the new status will be reflected by the  I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. | 
| [APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. 
Needs approval from an approver in each of these files:
 Approvers can indicate their approval by writing  | 
| /hold | 
| /ok-to-test | 
d1e453a    to
    251c9ea      
    Compare
  
    2e9255f    to
    b7fcf22      
    Compare
  
    | /test pull-cluster-api-provider-openstack-e2e-test | 
b7fcf22    to
    f11955c      
    Compare
  
    8d8b3c9    to
    ee2a77b      
    Compare
  
    ee2a77b    to
    2509267      
    Compare
  
    34e1f3c    to
    f75872e      
    Compare
  
    | @smoshiur1237 Just checking in on this. Do you have some time to look over the failing tests and fix them? | 
| I had a discussion with @lentzi90 and trying to explore different way of validation. The approach we are using may not cover the validation. I will get back on this soon. | 
ab79667    to
    8278271      
    Compare
  
    Signed-off-by: smoshiur1237 <[email protected]>
8278271    to
    e875709      
    Compare
  
    | @smoshiur1237: The following tests failed, say  
 Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. | 
This pr will be part of fix for image validation. At this moment invalid images are not reported to the describe log of the openstack machine. The goal is to improve the log situation by adding the image validation for image parameters.
Fixes #2265