Skip to content

Conversation

@smoshiur1237
Copy link
Contributor

This pr will be part of fix for image validation. At this moment invalid images are not reported to the describe log of the openstack machine. The goal is to improve the log situation by adding the image validation for image parameters.
Fixes #2265

@netlify
Copy link

netlify bot commented Aug 20, 2025

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit e875709
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-openstack/deploys/68cc58fcd1c61000088d5452
😎 Deploy Preview https://deploy-preview-2665--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 20, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: smoshiur1237 / name: Moshiur Rahman (e875709)

@k8s-ci-robot
Copy link
Contributor

Welcome @smoshiur1237!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-openstack has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 20, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @smoshiur1237. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lentzi90 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 20, 2025
@smoshiur1237
Copy link
Contributor Author

/hold
work in progress

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2025
@lentzi90
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 20, 2025
@smoshiur1237 smoshiur1237 force-pushed the image-validation-moshiur branch 2 times, most recently from d1e453a to 251c9ea Compare August 20, 2025 14:04
@smoshiur1237 smoshiur1237 force-pushed the image-validation-moshiur branch 2 times, most recently from 2e9255f to b7fcf22 Compare August 21, 2025 08:23
@smoshiur1237
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-test

@smoshiur1237 smoshiur1237 force-pushed the image-validation-moshiur branch from b7fcf22 to f11955c Compare August 26, 2025 07:52
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 26, 2025
@smoshiur1237 smoshiur1237 force-pushed the image-validation-moshiur branch 2 times, most recently from 8d8b3c9 to ee2a77b Compare August 26, 2025 10:07
@smoshiur1237 smoshiur1237 force-pushed the image-validation-moshiur branch from ee2a77b to 2509267 Compare August 26, 2025 10:22
@smoshiur1237 smoshiur1237 force-pushed the image-validation-moshiur branch 2 times, most recently from 34e1f3c to f75872e Compare September 17, 2025 07:30
@bnallapeta
Copy link
Contributor

@smoshiur1237 Just checking in on this. Do you have some time to look over the failing tests and fix them?
(would need a rebase too)

@smoshiur1237
Copy link
Contributor Author

I had a discussion with @lentzi90 and trying to explore different way of validation. The approach we are using may not cover the validation. I will get back on this soon.

@smoshiur1237 smoshiur1237 changed the title 🌱Add image validation for opestack machine 🌱Add image validation for openstack machine Sep 18, 2025
@smoshiur1237 smoshiur1237 force-pushed the image-validation-moshiur branch 3 times, most recently from ab79667 to 8278271 Compare September 18, 2025 19:05
@smoshiur1237 smoshiur1237 force-pushed the image-validation-moshiur branch from 8278271 to e875709 Compare September 18, 2025 19:09
@k8s-ci-robot
Copy link
Contributor

@smoshiur1237: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-openstack-test e875709 link true /test pull-cluster-api-provider-openstack-test
pull-cluster-api-provider-openstack-e2e-test e875709 link true /test pull-cluster-api-provider-openstack-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

Status: Inbox

Development

Successfully merging this pull request may close these issues.

Missing image is hard to debug

5 participants