Skip to content

Conversation

@mdbooth
Copy link
Contributor

@mdbooth mdbooth commented Mar 20, 2024

Also make IdentityRef required, as it doesn't currently permit fallback to cluster credentials.

cc @bilbobrovall @huxcrux

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 20, 2024
@k8s-ci-robot k8s-ci-robot requested a review from EmilienM March 20, 2024 11:46
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2024
@k8s-ci-robot k8s-ci-robot requested a review from lentzi90 March 20, 2024 11:46
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 20, 2024
@netlify
Copy link

netlify bot commented Mar 20, 2024

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 24b7961
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/65fadfd65073a500088e9656
😎 Deploy Preview https://deploy-preview-1962--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdbooth
Copy link
Contributor Author

mdbooth commented Mar 20, 2024

size/L. I'm guessing that means either it didn't work, or the .gitattributes change isn't applied to this PR. The non-generated diffstat is actually:

api/v1alpha1/openstackfloatingippool_types.go     | 18 +++++-------------
controllers/openstackfloatingippool_controller.go |  7 +++----
pkg/scope/provider.go                             | 12 +++---------
3 files changed, 11 insertions(+), 26 deletions(-)

Also make IdentityRef required, as it doesn't currently permit fallback
to cluster credentials.
@mdbooth
Copy link
Contributor Author

mdbooth commented Mar 20, 2024

/test pull-cluster-api-provider-openstack-e2e-full-test

@huxcrux
Copy link
Contributor

huxcrux commented Mar 20, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2024
@dulek
Copy link
Contributor

dulek commented Mar 20, 2024

/lgtm

@mdbooth
Copy link
Contributor Author

mdbooth commented Mar 20, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2024
@k8s-ci-robot k8s-ci-robot merged commit 99f3a60 into kubernetes-sigs:main Mar 20, 2024
@pierreprinetti pierreprinetti deleted the floatingipv1beta1 branch October 16, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants