Skip to content

🌱 Make it possible to use a pre-created volume type in e2e tests #1766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 21, 2023
Merged

🌱 Make it possible to use a pre-created volume type in e2e tests #1766

merged 1 commit into from
Dec 21, 2023

Conversation

@maxrantil
Copy link

Which issue(s) this PR fixes:
Fixes #1700

TODOs:

  • [ X] squashed commits

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2023
@netlify
Copy link

netlify bot commented Dec 1, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit a45a6a9
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6582de52fa8cf10008a96e9e
😎 Deploy Preview https://deploy-preview-1766--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 1, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @maxrantil. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 1, 2023
@maxrantil
Copy link
Author

/cc @lentzi90
Is this what you had in mind for the issue? Im not sure about the conf variable name that is being used. Should we use a new variable name?

@k8s-ci-robot k8s-ci-robot requested a review from lentzi90 December 1, 2023 18:33
lentzi90
lentzi90 reviewed Dec 4, 2023
View reviewed changes
Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
I think we could even do so that if the volume type does not exist we just error out directly, without trying to create it. For the CI, we can pre-create it here together with the flavors.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 4, 2023
@maxrantil maxrantil force-pushed the e2e-enable-own-openstack/max branch 4 times, most recently from ef581dc to 75ea552 Compare December 4, 2023 13:04
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 4, 2023
lentzi90
lentzi90 reviewed Dec 4, 2023
View reviewed changes
@maxrantil maxrantil force-pushed the e2e-enable-own-openstack/max branch 2 times, most recently from de73665 to 3c9c3ca Compare December 5, 2023 05:14
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 5, 2023
@maxrantil maxrantil force-pushed the e2e-enable-own-openstack/max branch 6 times, most recently from 984e52b to 0359fc8 Compare December 8, 2023 17:48
@maxrantil
Copy link
Author

/test pull-cluster-api-provider-openstack-e2e-test

@maxrantil maxrantil force-pushed the e2e-enable-own-openstack/max branch 8 times, most recently from b6e4d3c to 17efa60 Compare December 19, 2023 16:04
@maxrantil maxrantil changed the title WIP: 🌱 Make it able to bring your own OpenStack volume type 🌱 Make it able to bring your own OpenStack volume type Dec 19, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 19, 2023
@maxrantil
Copy link
Author

/cc @lentzi90

lentzi90
lentzi90 reviewed Dec 20, 2023
View reviewed changes
Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good overall. I'm not understanding why we have the getVolumeType though, and we should preferably not use admin credentials at all

@maxrantil maxrantil force-pushed the e2e-enable-own-openstack/max branch from 5eef099 to a45a6a9 Compare December 20, 2023 12:30
@maxrantil maxrantil changed the title 🌱 Make it able to bring your own OpenStack volume type 🌱 Make it possible to use a pre-created volume type in e2e tests Dec 20, 2023
@maxrantil
Copy link
Author

maxrantil commented Dec 20, 2023 •
edited
Loading

You are right @lentzi90 , the function is now completely gone.

/cc @jichenjc @mdbooth @dulek

@k8s-ci-robot k8s-ci-robot requested a review from dulek December 20, 2023 13:55
lentzi90
lentzi90 reviewed Dec 21, 2023
View reviewed changes
Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90, maxrantil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2023
@jichenjc
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 21, 2023
@maxrantil
Copy link
Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 21, 2023
@lentzi90
Copy link
Contributor

/test pull-cluster-api-provider-openstack-e2e-test

@k8s-ci-robot k8s-ci-robot merged commit 3707a7c into kubernetes-sigs:main Dec 21, 2023
@lentzi90 lentzi90 deleted the e2e-enable-own-openstack/max branch April 17, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@jichenjc jichenjc Awaiting requested review from jichenjc

@mdbooth mdbooth Awaiting requested review from mdbooth

@dulek dulek Awaiting requested review from dulek

Assignees

@jichenjc jichenjc

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

E2e: Enable bring your own OpenStack

5 participants

@maxrantil @k8s-ci-robot @jichenjc @dulek @lentzi90