🐛Fix failing clusterctl upgrade test (second attempt)

[mdbooth]

Fixes #1658

/hold

[netlify]

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name	Link
🔨 Latest commit	bf132f1
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/64faf329be7ec600087704fc
😎 Deploy Preview	https://deploy-preview-1661--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mdbooth]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mdbooth]

/test pull-cluster-api-provider-openstack-e2e-full-test

[lentzi90]

Oh I think I see what is going on now. In the e2e tests, we do not fetch components from github, since it is desirable to test things that are not released yet. The e2e tests are configured to create a "repository" with precisely what we need for the test based on the e2e config, instead of just fetching releases from GH. This means that if we want older versions of any provider, we must specify that in the config. For CAPO we already have that, but not for CAPI. For CAPI we only specify v1.5.0.

For reference, this is the folder structure and config that is created for the e2e tests: https://gcsweb.k8s.io/gcs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-openstack/1661/pull-cluster-api-provider-openstack-e2e-full-test/1700060262884708352/artifacts/repository/
As can be seen there, we only have CAPI v1.5.0 components available.

[mdbooth]

/test pull-cluster-api-provider-openstack-e2e-full-test

[lentzi90]

This looks correct!
/lgtm
Let's see what the CI thinks 🤞

[mdbooth]

I think the confusion here is that we previously didn't need to update CAPI itself during this test so we didn't have separate config. Now the test doesn't work against v1.5.x, so we do need it. 🤞 this fixes it.

[lentzi90]

Where is the CAPI v1.3.6 coming from 🤔

[mdbooth]

Where is the CAPI v1.3.6 coming from 🤔

I think that was the previous run. The new run succeeded.

Now to see why the e2e-test failed.

[mdbooth]

/test pull-cluster-api-provider-openstack-e2e-test

[lentzi90]

Oh 🤦 I must have missed to reload the browser tab 😂

[mdbooth]

Probably a flake, but it looks like the failure was in cleanup:

I0908 12:06:23.245291       1 loadbalancer.go:503] "Deleting load balancer" controller="openstackcluster" controllerGroup="infrastructure.cluster.x-k8s.io" controllerKind="OpenStackCluster" OpenStackCluster="e2e-06sftj/cluster-e2e-06sftj" namespace="e2e-06sftj" reconcileID=7c5e495a-187e-4f8b-aa1b-cd32855ad8b0 cluster="cluster-e2e-06sftj" name="k8s-clusterapi-cluster-e2e-06sftj-cluster-e2e-06sftj-kubeapi" cascade=true
I0908 12:06:23.326402       1 recorder.go:104] "events: Failed to delete load balancer k8s-clusterapi-cluster-e2e-06sftj-cluster-e2e-06sftj-kubeapi with id 7ea788ab-90ad-45ec-a50b-6726f183e730: Expected HTTP response code [202 204] when accessing [DELETE http://10.0.3.15/load-balancer/v2.0/lbaas/loadbalancers/7ea788ab-90ad-45ec-a50b-6726f183e730?cascade=true], but got 409 instead\n{\"faultcode\": \"Client\", \"faultstring\": \"Invalid state DELETED of loadbalancer resource 7ea788ab-90ad-45ec-a50b-6726f183e730\", \"debuginfo\": null}" type="Warning" object={Kind:OpenStackCluster Namespace:e2e-06sftj Name:cluster-e2e-06sftj UID:cae01ab4-a51f-47e1-88f1-d368ac7abce1 APIVersion:infrastructure.cluster.x-k8s.io/v1alpha7 ResourceVersion:9595 FieldPath:} reason="Faileddeleteloadbalancer"
E0908 12:06:23.345463       1 controller.go:324] "Reconciler error" err=<
	failed to delete load balancer: Expected HTTP response code [202 204] when accessing [DELETE http://10.0.3.15/load-balancer/v2.0/lbaas/loadbalancers/7ea788ab-90ad-45ec-a50b-6726f183e730?cascade=true], but got 409 instead
	{"faultcode": "Client", "faultstring": "Invalid state DELETED of loadbalancer resource 7ea788ab-90ad-45ec-a50b-6726f183e730", "debuginfo": null}

Looks like a separate bug.

[mdbooth]

The relevant test passed! e2e test failure looks like a flake.

/hold cancel