Skip to content

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: only unmount kata volume if it's kata node

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

fix: only unmount kata volume if it's kata node

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 23, 2025
@k8s-ci-robot k8s-ci-robot requested a review from cvvz July 23, 2025 08:40
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from ZeroMagic July 23, 2025 08:41
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 23, 2025
@andyzhangx andyzhangx merged commit 8c343ec into master Jul 24, 2025
27 of 28 checks passed
@andyzhangx
Copy link
Member Author

/cherrypick release-1.33

@andyzhangx
Copy link
Member Author

/cherrypick release-1.32

@k8s-infra-cherrypick-robot

@andyzhangx: new pull request created: #2691

In response to this:

/cherrypick release-1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@andyzhangx: #2688 failed to apply on top of branch "release-1.32":

Applying: fix: only unmount kata volume if it's kata node
Using index info to reconstruct a base tree...
M	pkg/azurefile/nodeserver.go
M	pkg/azurefile/nodeserver_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/azurefile/nodeserver_test.go
Auto-merging pkg/azurefile/nodeserver.go
CONFLICT (content): Merge conflict in pkg/azurefile/nodeserver.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 fix: only unmount kata volume if it's kata node

In response to this:

/cherrypick release-1.32

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@andyzhangx
Copy link
Member Author

/cherrypick release-1.32

@k8s-infra-cherrypick-robot

@andyzhangx: new pull request created: #2696

In response to this:

/cherrypick release-1.32

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants